Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 29, 2025

PR-Codex overview

This PR focuses on updating the @thirdweb-dev/service-utils package, including version bumping, adding a new property billingPlanVersion, and enhancing documentation regarding Nebula's supported contracts.

Detailed summary

  • Updated version in packages/service-utils/package.json from 0.7.2 to 0.7.3.
  • Added billingPlanVersion property to mocks.ts and api.ts.
  • Updated CHANGELOG.md to include details for version 0.7.3.
  • Expanded documentation in page.mdx regarding supported contracts for Nebula.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

saminacodes and others added 4 commits January 29, 2025 01:03
NEB-82

## Notes for the reviewer

Documentation changes

## How to test

No testing needed

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds information about the contracts supported by `Nebula` and provides guidance on enabling deployment for published contracts. It also updates the section on pricing options, ensuring consistency in the text.

### Detailed summary
- Added a new section titled "Which contracts does Nebula support?" detailing supported contract types.
- Included links to `Token - ERC20`, `NFT Collection - ERC721`, `Edition - ERC1155`, and `Split` contracts.
- Provided a contact link for enabling published contracts for deployment.
- Updated the `Pricing` section for clarity, removing the newline at the end.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jnsdls jnsdls requested review from a team as code owners January 29, 2025 19:33
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 69549b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:33pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:33pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:33pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:33pm

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Jan 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@jnsdls jnsdls merged commit cfa1c20 into main Jan 29, 2025
31 of 34 checks passed
@jnsdls jnsdls deleted the saminacodes-patch-1 branch January 29, 2025 19:34
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 835 ms (+29.81% 🔺) 1.8 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 1.6 s (+8.61% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 91 ms (+68.51% 🔺) 203 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (-31.46% 🔽) 20 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 187 ms (-8.7% 🔽) 573 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants