-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] feat: Optional wallet activation during connection #6105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] feat: Optional wallet activation during connection #6105
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 747e4e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
dd3d1e9 to
747e4e2
Compare
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
| "AccountProvider: No address passed. Ensure an address is always provided to the AccountProvider", | ||
| ); | ||
| } | ||
| if (!isAddress(props.address)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't wanna throw and break the page on bad input here, should throw inside the queries instead
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
+ Coverage 56.87% 56.89% +0.02%
==========================================
Files 1152 1153 +1
Lines 63907 63893 -14
Branches 5184 5186 +2
==========================================
+ Hits 36344 36349 +5
+ Misses 26834 26816 -18
+ Partials 729 728 -1
*This pull request uses carry forward flags. Click here to find out more.
|

PR-Codex overview
This PR introduces an enhancement to the
useConnectfunctionality, allowing users to connect wallets without necessarily setting them as active. This provides more flexibility in wallet management.Detailed summary
createConnectionManagerfunction to include an optionalsetWalletAsActiveparameter.setWalletAsActiveis not explicitly set tofalse.