Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 29, 2025


PR-Codex overview

This PR introduces an enhancement to the useConnect functionality, allowing users to connect wallets without necessarily setting them as active. This provides more flexibility in wallet management.

Detailed summary

  • Updated the createConnectionManager function to include an optional setWalletAsActive parameter.
  • Modified the logic to only set the active wallet if setWalletAsActive is not explicitly set to false.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:11pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:11pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:11pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:11pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 747e4e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.59 KB (+0.09% 🔺) 932 ms (+0.09% 🔺) 382 ms (+32.56% 🔺) 1.4 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 652 ms (+19.9% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 109 ms (+361.93% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 20 ms (+341.14% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (-0.16% 🔽) 385 ms (-0.16% 🔽) 76 ms (+28.22% 🔺) 461 ms

@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Optional_wallet_activation_during_connection branch from dd3d1e9 to 747e4e2 Compare January 29, 2025 21:01
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 29, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

"AccountProvider: No address passed. Ensure an address is always provided to the AccountProvider",
);
}
if (!isAddress(props.address)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't wanna throw and break the page on bad input here, should throw inside the queries instead

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (f5f8a40) to head (747e4e2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6105      +/-   ##
==========================================
+ Coverage   56.87%   56.89%   +0.02%     
==========================================
  Files        1152     1153       +1     
  Lines       63907    63893      -14     
  Branches     5184     5186       +2     
==========================================
+ Hits        36344    36349       +5     
+ Misses      26834    26816      -18     
+ Partials      729      728       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f5f8a40
packages 55.08% <100.00%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...kages/thirdweb/src/react/core/account/provider.tsx 80.00% <ø> (ø)
...ckages/thirdweb/src/react/core/utils/walletname.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/wallets/manager/index.ts 87.23% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit ab55aec into main Jan 29, 2025
31 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_feat_Optional_wallet_activation_during_connection branch January 29, 2025 22:21
@joaquim-verges joaquim-verges mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants