Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 29, 2025


PR-Codex overview

This PR focuses on updating the import path for the deployContract function in the deploy-with-abi.ts file to reflect a change in the module structure.

Detailed summary

  • Changed the import statement for deployContract from "thirdweb/deployContract" to "thirdweb/deploys" in packages/thirdweb/src/contract/deployment/deploy-with-abi.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 29, 2025 23:14
@linear
Copy link

linear bot commented Jan 29, 2025

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:22pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:22pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:22pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:22pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 303 ms (+113.71% 🔺) 1.3 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 392 ms (-17.56% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 82 ms (+232.77% 🔺) 194 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (+88.5% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 87 ms (+164.9% 🔺) 472 ms

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (1ee0dff) to head (0e3ce33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6108      +/-   ##
==========================================
- Coverage   56.89%   56.89%   -0.01%     
==========================================
  Files        1153     1153              
  Lines       63893    63893              
  Branches     5182     5180       -2     
==========================================
- Hits        36353    36349       -4     
- Misses      26812    26816       +4     
  Partials      728      728              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1ee0dff
packages 55.08% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/contract/deployment/deploy-with-abi.ts 78.88% <ø> (ø)

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit c5d4cab into main Jan 30, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the greg/tool-3263-fix-deploycontract-documentation-imports branch January 30, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants