Skip to content

[SDK] Fix: skip factory entrypoint lookup for ZKsync chains #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2025
Merged

[SDK] Fix: skip factory entrypoint lookup for ZKsync chains #6116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2bfc8
skip factory entrypoint lookup for ZKsync chains
alecananian Jan 30, 2025
47dc301
optimize zksync check position
alecananian Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-adults-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Skip factory entrypoint lookup for ZKsync chains
27 changes: 13 additions & 14 deletions packages/thirdweb/src/wallets/smart/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,19 @@

const options = creationOptions;
const chain = connectChain ?? options.chain;
const sponsorGas =
"gasless" in options ? options.gasless : options.sponsorGas;
if (await isZkSyncChain(chain)) {
return [
createZkSyncAccount({
creationOptions,
connectionOptions,
chain,
sponsorGas,
}),
chain,
];
}

Check warning on line 110 in packages/thirdweb/src/wallets/smart/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/smart/index.ts#L98-L110 

Added lines #L98 - L110 were not covered by tests

// if factory is passed, but no entrypoint, try to resolve entrypoint from factory
if (options.factoryAddress && !options.overrides?.entrypointAddress) {
Expand Down Expand Up @@ -125,20 +138,6 @@
const factoryAddress =
options.factoryAddress ??
getDefaultAccountFactory(options.overrides?.entrypointAddress);
const sponsorGas =
"gasless" in options ? options.gasless : options.sponsorGas;

if (await isZkSyncChain(chain)) {
return [
createZkSyncAccount({
creationOptions,
connectionOptions,
chain,
sponsorGas,
}),
chain,
];
}

const factoryContract = getContract({
client: client,
Expand Down
Loading