[SDK] Fix: Switch underlying admin wallet with ecosystem smart account #6119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b693b78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
size-limit report 📦
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
joaquim-verges
approved these changes
Jan 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
==========================================
+ Coverage 56.89% 56.90% +0.01%
==========================================
Files 1153 1155 +2
Lines 63896 63915 +19
Branches 5184 5192 +8
==========================================
+ Hits 36353 36372 +19
- Misses 26815 26816 +1
+ Partials 728 727 -1
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
#6119) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the functionality of smart wallets in the `thirdweb` ecosystem, ensuring they correctly trigger chain switches and improving related wallet checks and configurations. ### Detailed summary - Fixed smart wallets to trigger chain switch on admin wallets. - Updated `smartWalletGetCapabilities` to accept a generic `Wallet` type. - Implemented `isSmartWallet` function to check for smart wallet status. - Modified `getSmartWallet` to throw an error for non-smart wallets. - Refactored wallet checks in `createConnectionManager`. - Added tests for `isSmartWallet` and `getSmartWallet`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
greg/tool-3272-switch-underlying-admin-wallet-with-ecosystem-smart-account
branch
from
88b23ee to
b693b78
Compare
graphite-app
bot
added
merge-queue
joaquim-verges
approved these changes
Jan 31, 2025
graphite-app
bot
deleted the
greg/tool-3272-switch-underlying-admin-wallet-with-ecosystem-smart-account
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the handling of smart wallets in the
thirdwebecosystem, ensuring proper chain switching functionality and enhancing type safety and capability checks for smart wallets.Detailed summary
smartWalletGetCapabilitiesto accept a genericWallettype.isSmartWalletfunction for checking smart wallet status.wallet.iddirectly.getSmartWalletfunction to throw errors for non-smart wallets.isSmartWalletandgetSmartWalletfunctions.