Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 30, 2025

PR-Codex overview

This PR focuses on enhancing the UsageV2Producer class in the service-utils package by allowing configuration overrides for Kafka producer initialization and message sending, including options for acknowledgments, timeout, and compression.

Detailed summary

  • Modified the init method of UsageV2Producer to accept optional configOverrides of type ProducerConfig.
  • Updated the sendEvents method to accept an optional configOverrides parameter with options for acks, timeout, and compression.
  • Integrated default values for acks, timeout, and compression in the sendEvents method while allowing overrides.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner January 30, 2025 20:36
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 1e3f2e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:38pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:38pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:38pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:38pm

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (c650221) to head (1e3f2e6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6120   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c650221
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@arcoraven arcoraven merged commit a22457a into main Jan 30, 2025
31 of 32 checks passed
@arcoraven arcoraven deleted the ph/tuneKafkajs branch January 30, 2025 20:38
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 285 ms (-13.65% 🔽) 1.3 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 981 ms (-9.27% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 176 ms (+213.64% 🔺) 288 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (+75.79% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 177 ms (+66.3% 🔺) 562 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants