Skip to content

update login permissions UI and styling #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

update login permissions UI and styling #6128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/login/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default function RootLayout({
children: React.ReactNode;
}>) {
return (
<html lang="en" className="h-full w-full">
<html lang="en" className="h-full w-full bg-black text-white">
<body
className={`${sansFont.variable} ${monoFont.variable} h-full w-full font-sans antialiased`}
>
Expand Down
135 changes: 77 additions & 58 deletions apps/login/src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
"use client";

import { useSearchParams } from "next/navigation";
import { createThirdwebClient, getContract, sendTransaction } from "thirdweb";
import { createThirdwebClient, getContract } from "thirdweb";
import { baseSepolia } from "thirdweb/chains";
import { addSessionKey, isActiveSigner } from "thirdweb/extensions/erc4337";
import { ConnectEmbed, useActiveAccount } from "thirdweb/react";
import {
ConnectEmbed,
TransactionButton,
useActiveAccount,
} from "thirdweb/react";
import { isContractDeployed } from "thirdweb/utils";

const sesionKeySignerAddress = "0x6f700ba0258886411D2536399624EAa7158d1742";
Expand All @@ -16,41 +20,6 @@ const client = createThirdwebClient({
export default function Page() {
const account = useActiveAccount();

const onAccept = async () => {
if (!account) {
throw new Error("No account found");
}
const accountContract = getContract({
address: account.address,
// hard coded for now
chain: baseSepolia,
client,
});
let hasSesionKey = false;
// check if already added
const accountDeployed = await isContractDeployed(accountContract);
if (accountDeployed) {
hasSesionKey = await isActiveSigner({
contract: accountContract,
signer: sesionKeySignerAddress,
});
}
// if not added, send tx to add the session key
if (!hasSesionKey) {
const transaction = addSessionKey({
account,
contract: accountContract,
sessionKeyAddress: sesionKeySignerAddress,
// hard coded for now
permissions: { approvedTargets: "*" },
});
await sendTransaction({
account,
transaction,
});
}
};

const searchParams = useSearchParams();
const code = searchParams.get("code");
const clientId = searchParams.get("clientId");
Expand All @@ -61,32 +30,82 @@ export default function Page() {
return (
<div className="grid h-full w-full place-items-center">
{account ? (
<div>
<h1>Permissions Screen</h1>
<div className="flex flex-col gap-4 rounded-lg border border-gray-800 p-12">
<h1 className="font-bold text-3xl">Grant Permissions</h1>
<p>
<strong>App.xyz</strong> is asking you to grant it the following
permissions:
</p>
<ul>
<li>perm 1</li>
<li>perm 2</li>
<li>perm 3</li>
<li>✅ Receive your identity information.</li>
<li>
✅ Interact with <strong>all</strong> contracts on{" "}
<strong>Base Sepolia</strong>
</li>
<li>
✅ Spend <strong>all</strong> your funds on{" "}
<strong>Base Sepolia</strong>
</li>
</ul>
<button
type="button"
onClick={() => {
onAccept()
.then(() => {
// redirect back to the app
window.location.href = `${redirect}${encodeHash(
account.address,
sesionKeySignerAddress,
code || "",
)}`;
})
.catch((e) => {
console.error("failed", e);
<p>
By approving below you will grant <strong>App.xyz</strong> these
permissions until <strong>02/02/2025</strong>.
</p>
<TransactionButton
transaction={async () => {
if (!account) {
throw new Error("No account found");
}
const accountContract = getContract({
address: account.address,
// hard coded for now
chain: baseSepolia,
client,
});
let hasSesionKey = false;
// check if already added
const accountDeployed = await isContractDeployed(accountContract);
if (accountDeployed) {
hasSesionKey = await isActiveSigner({
contract: accountContract,
signer: sesionKeySignerAddress,
});
}
// if not added, send tx to add the session key
if (!hasSesionKey) {
return addSessionKey({
account,
contract: accountContract,
sessionKeyAddress: sesionKeySignerAddress,
// hard coded for now
permissions: { approvedTargets: "*" },
});
}
throw "already-added";
}}
onError={(e) => {
if (typeof e === "string" && e === "already-added") {
// redirect back to the app
window.location.href = `${redirect}${encodeHash(
account.address,
sesionKeySignerAddress,
code || "",
)}`;
} else {
console.error(e);
}
}}
onTransactionConfirmed={() => {
// redirect back to the app
window.location.href = `${redirect}${encodeHash(
account.address,
sesionKeySignerAddress,
code || "",
)}`;
}}
>
Accept
</button>
Approve
</TransactionButton>
</div>
) : (
<ConnectEmbed
Expand Down
Loading