-
Notifications
You must be signed in to change notification settings - Fork 619
add knip dependency to login app #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6135 +/- ##
==========================================
+ Coverage 56.87% 56.89% +0.01%
==========================================
Files 1153 1153
Lines 63896 63896
Branches 5180 5184 +4
==========================================
+ Hits 36344 36353 +9
+ Misses 26825 26815 -10
- Partials 727 728 +1
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
223ae9c to
3688141
Compare

fixes: CORE-719
TL;DR
Added Knip dependency to the login application for dead code detection
What changed?
knipversion 5.43.6 as a development dependency to the login applicationHow to test?
pnpm installin the login application directorypnpm knip --versionWhy make this change?
Knip is a static analysis tool that helps identify unused exports, files, and dependencies. Adding this tool will help maintain a cleaner codebase by detecting and removing dead code in the login application.
PR-Codex overview
This PR primarily focuses on updating dependencies in the project, including the addition of new packages and configuration files, as well as refining existing package versions.
Detailed summary
knippackage (version5.43.6) toapps/login/package.json.postcss-load-configpackage (version^6.0.1) toapps/login/package.json.knip.jsonconfiguration file with specific settings.pnpm-lock.yamlto reflect new versions and removed some nested dependencies.