Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 1, 2025

PR-Codex overview

This PR updates the service-utils package to use ECMAScript Modules (ESM) and modifies the UsageV2Producer class to change the compression handling from a specified algorithm to a boolean flag indicating whether to compress events.

Detailed summary

  • Updated service-utils to ESM for compression types.
  • Removed CommonJS import pattern for KafkaJS.
  • Changed compression property to shouldCompress in UsageV2Producer.
  • Default value for shouldCompress set to true.
  • Updated logic to determine compression based on shouldCompress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 1, 2025 00:14
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025

🦋 Changeset detected

Latest commit: 3ae638b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:29am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:29am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:29am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:29am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:29am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (b693b78) to head (3ae638b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6139   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files        1155     1155           
  Lines       63915    63915           
  Branches     5192     5192           
=======================================
  Hits        36372    36372           
  Misses      26816    26816           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 01b058b
packages 55.10% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@arcoraven arcoraven merged commit f4f93e6 into main Feb 1, 2025
8 of 13 checks passed
@arcoraven arcoraven deleted the ph/usageV2FixImports branch February 1, 2025 00:17
@joaquim-verges joaquim-verges mentioned this pull request Feb 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 2.6 s (+11.01% 🔺) 3.5 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 7.5 s (+3.8% 🔺) 10 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 573 ms (+80.95% 🔺) 684 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 42 ms (-59.82% 🔽) 52 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 387 ms (0%) 789 ms (+34.15% 🔺) 1.2 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants