Skip to content

Conversation

@Pronoss
Copy link

@Pronoss Pronoss commented Feb 3, 2025

This PR updates function names and error messages in the SDK to improve consistency, clarity, and maintainability. These changes align the codebase with proper naming conventions and enhance error reporting.

Changes:

  • Updated function name from getTransactionsForMaketplaceV3getTransactionsForMarketplaceV3 in get-required-transactions.ts to ensure correct spelling and consistency.
  • Fixed error message typo: "Unknown upload error occured""Unknown upload error occurred" in mobile.ts for improved clarity.

Why This Change?

  • Ensures function names follow a consistent convention, preventing confusion.
  • Improves error messaging to enhance debugging and troubleshooting.
  • Contributes to overall code quality and maintainability.

Risks

Low – These updates do not alter functionality but improve naming and error messages.


PR-Codex overview

This PR focuses on correcting typos in the codebase, specifically in the error messages and function names related to marketplace transactions.

Detailed summary

  • Fixed typo in mobile.ts: "occurred" instead of "occured".
  • Corrected function name from getTransactionsForMaketplaceV3 to getTransactionsForMarketplaceV3 in get-required-transactions.ts.
  • Updated function definition to match the corrected name.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Pronoss Pronoss requested review from a team as code owners February 3, 2025 17:08
@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 3f6c424

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 3, 2025
@vercel
Copy link

vercel bot commented Feb 3, 2025

@Pronoss is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants