Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 5, 2025

PR-Codex overview

This PR focuses on enhancing the service-utils package by fixing the import of CompressionCodecs, updating types, and modifying the getTopicName function to accept a broader range of sources. It also includes adjustments to package dependencies and configuration.

Detailed summary

  • Added missing CompressionCodecs import in usageV2.ts.
  • Changed getTopicName function to accept UsageV2Source instead of ServiceName.
  • Updated productName to source in UsageV2Producer class.
  • Adjusted dependency versions in package.json and pnpm-lock.yaml.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 5, 2025 03:26
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 46ed36e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven merged commit 821caa6 into main Feb 5, 2025
23 of 28 checks passed
@arcoraven arcoraven deleted the ph/reintroduceNamedExport branch February 5, 2025 03:31
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (cf166e4) to head (46ed36e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6164      +/-   ##
==========================================
- Coverage   56.92%   56.92%   -0.01%     
==========================================
  Files        1155     1155              
  Lines       63920    63923       +3     
  Branches     5195     5193       -2     
==========================================
- Hits        36388    36386       -2     
- Misses      26804    26808       +4     
- Partials      728      729       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cf166e4
packages 55.12% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@joaquim-verges joaquim-verges mentioned this pull request Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 539 ms (+12.73% 🔺) 1.5 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 1.3 s (-17.64% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 222 ms (+600.35% 🔺) 334 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 35 ms (+24.14% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 292 ms (+102.47% 🔺) 678 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants