Skip to content

Conversation

@catalyst17
Copy link
Contributor

@catalyst17 catalyst17 commented Feb 5, 2025


PR-Codex overview

This PR introduces a new property, canCreatePublicChains, to the TeamResponse interface and updates the mock data accordingly.

Detailed summary

  • Added canCreatePublicChains property to TeamResponse with a default value of false in mocks.ts.
  • Updated TeamResponse interface in api.ts to include canCreatePublicChains as a type of boolean | null.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:57pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:57pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:57pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:57pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:57pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 07:19 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: f22f804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 5, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 07:19 Inactive
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@catalyst17 catalyst17 marked this pull request as ready for review February 5, 2025 07:20
@catalyst17 catalyst17 requested a review from a team as a code owner February 5, 2025 07:20
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (0781da9) to head (a8ac98b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6172   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5197     5197           
=======================================
  Hits        36479    36479           
  Misses      27053    27053           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0781da9
packages 54.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 938 ms (+109.8% 🔺) 1.9 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 1.4 s (+0.32% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 454 ms (+705.83% 🔺) 566 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 60 ms (+114.79% 🔺) 70 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 171 ms (+10.48% 🔺) 556 ms

@catalyst17 catalyst17 marked this pull request as draft February 6, 2025 06:32
@catalyst17 catalyst17 force-pushed the feat/allowedToCreateChains_in_TeamResponse branch from 5794a16 to af8afb0 Compare February 7, 2025 07:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 7, 2025 07:14 Inactive
@catalyst17 catalyst17 marked this pull request as ready for review February 7, 2025 07:14
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a changeset (patch) pnpm changeset please

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Feb 7, 2025
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding the `canCreatePublicChains` property to the `mocks.ts` and modifying its type in `api.ts` to enhance the API's capabilities regarding public chain creation.

### Detailed summary
- Added `canCreatePublicChains: false` to the object in `mocks.ts`.
- Updated the type of `canCreatePublicChains` in `api.ts` to `boolean | null`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the feat/allowedToCreateChains_in_TeamResponse branch from af8afb0 to b140de7 Compare February 7, 2025 19:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 7, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 19:36 Inactive
@catalyst17 catalyst17 marked this pull request as draft February 7, 2025 19:42
@catalyst17 catalyst17 changed the title feat: allowedToCreateChains in TeamResponse feat: canCreatePublicChains in TeamResponse Feb 7, 2025
catalyst17 added a commit that referenced this pull request Feb 7, 2025
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding the `canCreatePublicChains` property to the `mocks.ts` and modifying its type in `api.ts` to enhance the API's capabilities regarding public chain creation.

### Detailed summary
- Added `canCreatePublicChains: false` to the object in `mocks.ts`.
- Updated the type of `canCreatePublicChains` in `api.ts` to `boolean | null`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@catalyst17 catalyst17 force-pushed the feat/allowedToCreateChains_in_TeamResponse branch from b140de7 to f22f804 Compare February 7, 2025 19:49
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding the `canCreatePublicChains` property to the `mocks.ts` and modifying its type in `api.ts` to enhance the API's capabilities regarding public chain creation.

### Detailed summary
- Added `canCreatePublicChains: false` to the object in `mocks.ts`.
- Updated the type of `canCreatePublicChains` in `api.ts` to `boolean | null`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants