Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 5, 2025

PR-Codex overview

This PR updates the content of the NotFoundPage component to improve the user experience by changing the messaging displayed when a page is not found.

Detailed summary

  • Updated the message from "Looks like web3 can't be found here." to "Looks like you're lost!".
  • Changed the prompt from "Try our" to "Find live content on our".
  • Adjusted the sentence structure by replacing "instead" with a period for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested review from a team as code owners February 5, 2025 09:42
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:42pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 5, 2025 2:42pm
login ⬜️ Skipped (Inspect) Feb 5, 2025 2:42pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 5, 2025 2:42pm
wallet-ui ⬜️ Skipped (Inspect) Feb 5, 2025 2:42pm

@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 09:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 5, 2025 09:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 09:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 09:43 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 9a432af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 5, 2025
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (ee6bd4f) to head (9a432af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6173   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files        1155     1155           
  Lines       63923    63923           
  Branches     5193     5193           
=======================================
  Hits        36386    36386           
  Misses      26808    26808           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ee6bd4f
packages 55.12% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 504 ms (+54.98% 🔺) 1.5 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 814 ms (-15.78% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 229 ms (+209.61% 🔺) 341 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (-40.41% 🔽) 32 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 159 ms (+31.73% 🔺) 545 ms

@arcoraven
Copy link
Contributor Author

image

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 5, 2025
Copy link
Contributor Author

arcoraven commented Feb 5, 2025

Merge activity

  • Feb 5, 9:12 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 5, 9:34 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 5, 9:43 AM EST: A user merged this pull request with the Graphite merge queue.

<!-- start pr-codex -->

## PR-Codex overview
This PR updates the content of the `NotFoundPage` component to enhance the user experience by changing the messaging displayed when a page is not found.

### Detailed summary
- Changed the message from "Looks like web3 can't be found here." to "Looks like you're lost!".
- Updated the text from "Try our" to "Find live content on our".
- Removed "instead" and added a period after the `TrackedLinkTW` component.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 5, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 14:35 Inactive
@graphite-app graphite-app bot merged commit 9a432af into main Feb 5, 2025
33 checks passed
@graphite-app graphite-app bot deleted the ph/404update branch February 5, 2025 14:43
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 5, 2025 14:43 Inactive
@vercel vercel bot temporarily deployed to Production – login February 5, 2025 14:43 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 5, 2025 14:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants