Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Feb 5, 2025

PR-Codex overview

This PR focuses on updating the framer-rewrites.js file by modifying the routing paths for the application. It adds a new route and organizes existing routes for clarity.

Detailed summary

  • Added the route "/connect/universal-bridge".
  • Maintained the existing routes "/connect/pay" and "/connect/account-abstraction".
  • Preserved the route "/nebula".
  • Removed the comment // --insight.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 5, 2025 18:25
@linear
Copy link

linear bot commented Feb 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 769a927

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 6:56pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 5, 2025 6:56pm
login ⬜️ Skipped (Inspect) Feb 5, 2025 6:56pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 5, 2025 6:56pm
wallet-ui ⬜️ Skipped (Inspect) Feb 5, 2025 6:56pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (ceff873) to head (769a927).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6176   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files        1155     1155           
  Lines       63923    63923           
  Branches     5193     5193           
=======================================
  Hits        36386    36386           
  Misses      26808    26808           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ceff873
packages 55.12% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (+0.03% 🔺) 933 ms (+0.03% 🔺) 227 ms (+91.84% 🔺) 1.2 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 309 ms (+31.96% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 44 ms (+138.1% 🔺) 156 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (+44.99% 🔺) 19 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 56 ms (+198.21% 🔺) 442 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on modifying the routes in the `framer-rewrites.js` file for the dashboard application, specifically adding and updating certain paths.

### Detailed summary
- Added the route `"/connect/universal-bridge"`.
- Updated the existing route list by retaining `"/connect/pay"`, `"/connect/account-abstraction"`, and `"/nebula"`.
- Removed the comment indicating `// --insight`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-3316-dashboard-update-pay-to-universal-bridge branch from fa6f4a2 to 769a927 Compare February 5, 2025 18:53
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 5, 2025 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 18:54 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 5, 2025
@graphite-app graphite-app bot merged commit 769a927 into main Feb 5, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3316-dashboard-update-pay-to-universal-bridge branch February 5, 2025 18:57
@vercel vercel bot temporarily deployed to Production – login February 5, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 5, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 5, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 5, 2025 18:57 Inactive
// -- connect
"/connect",
"/connect/sign-in",
"/connect/pay",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this seems to be redirected to universal-bridge you should remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants