Skip to content

[SDK] Feature: Add support for forcing legacy transactions in chain configuration #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2025
Merged

[SDK] Feature: Add support for forcing legacy transactions in chain configuration #6180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3233f4e
feat: Add support for forcing legacy transactions in chain configuration
d4mr Feb 6, 2025
e10bb39
support general feeType on chain and prepareTransaction
d4mr Feb 6, 2025
3281375
fixed import
d4mr Feb 6, 2025
6fa3332
add chain to hardcoded list
joaquim-verges Feb 6, 2025
b2b1e46
Merge branch 'main' into pb/force-legacy
d4mr Feb 18, 2025
842c37e
update prepare transaction to use type instead of feetype
d4mr Feb 18, 2025
ce9bf53
Merge branch 'main' into pb/force-legacy
d4mr Feb 26, 2025
f4a26e1
remove export (lint error)
d4mr Feb 26, 2025
66fbe30
fallback to legacy if no baseBlockFee in last block
d4mr Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/thirdweb/src/chains/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ export type ChainOptions = {
increaseZeroByteCount?: boolean;
};
faucets?: Array<string>;
fees?: {
/**
* Whether to force legacy transactions (pre EIP-1559) for this chain
*/
forceLegacyTransactions?: boolean;
Copy link
Contributor

@gregfromstl gregfromstl Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like the boolean because its inflexible, a type: "legacy" might be better (and matches viem/ox APIs)

Copy link
Contributor

@gregfromstl gregfromstl Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also want this on the transaction level if the user is providing it

Copy link
Contributor Author

@d4mr d4mr Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed on both counts. So something like feeType: "legacy" | "eip1559"?

};
};

/**
Expand Down
27 changes: 15 additions & 12 deletions packages/thirdweb/src/gas/fee-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,21 @@
client: ThirdwebClient,
chain: Chain,
) {
// if chain is in the force gas price list, always use gas price
if (!FORCE_GAS_PRICE_CHAIN_IDS.includes(chain.id)) {
const feeData = await getDynamicFeeData(client, chain);
if (
feeData.maxFeePerGas !== null &&
feeData.maxPriorityFeePerGas !== null
) {
return {
maxFeePerGas: feeData.maxFeePerGas,
maxPriorityFeePerGas: feeData.maxPriorityFeePerGas,
};
}
// if chain is configured to force legacy transactions or is in the legacy chain list
if (
chain.fees?.forceLegacyTransactions ||
FORCE_GAS_PRICE_CHAIN_IDS.includes(chain.id)
) {
return {
gasPrice: await getGasPrice({ client, chain, percentMultiplier: 10 }),
};
}

Check warning on line 125 in packages/thirdweb/src/gas/fee-data.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/gas/fee-data.ts#L122-L125 

Added lines #L122 - L125 were not covered by tests
const feeData = await getDynamicFeeData(client, chain);
if (feeData.maxFeePerGas !== null && feeData.maxPriorityFeePerGas !== null) {
return {
maxFeePerGas: feeData.maxFeePerGas,
maxPriorityFeePerGas: feeData.maxPriorityFeePerGas,
};
}
return {
gasPrice: await getGasPrice({ client, chain, percentMultiplier: 10 }),
Expand Down
Loading