Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 6, 2025

PR-Codex overview

This PR focuses on exposing the maxInFlightRequests option in the KafkaProducer class, allowing users to configure the maximum number of in-flight requests when sending messages.

Detailed summary

  • Added maxInFlightRequests to the KafkaProducerSendOptions interface in packages/service-utils/src/node/kafka.ts.
  • Updated the send method in KafkaProducer to utilize maxInFlightRequests.
  • Changed the type of options in UsageV2Producer to KafkaProducerSendOptions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 6, 2025 03:50
@vercel
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:05am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 6, 2025 4:05am
login ⬜️ Skipped (Inspect) Feb 6, 2025 4:05am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 6, 2025 4:05am
wallet-ui ⬜️ Skipped (Inspect) Feb 6, 2025 4:05am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 8f7c454

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 6, 2025 03:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 6, 2025 03:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 6, 2025 03:52 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 6, 2025 03:52 Inactive
if (!this.producer) {
this.producer = this.kafka.producer({
allowAutoTopicCreation: options?.allowAutoTopicCreation ?? false,
maxInFlightRequests: options?.maxInFlightRequests ?? 2000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kafkajs default is unlimited (meaning a server will try to send all requests immediately). This allows a buffer to control memory usage. Events that are backed up will be queued in memory.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (4e703fd) to head (8f7c454).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6181   +/-   ##
=======================================
  Coverage   56.93%   56.93%           
=======================================
  Files        1155     1155           
  Lines       63923    63923           
  Branches     5193     5193           
=======================================
  Hits        36392    36392           
  Misses      26803    26803           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from adc99b1
packages 55.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@arcoraven arcoraven merged commit dfd64d2 into main Feb 6, 2025
30 of 31 checks passed
@arcoraven arcoraven deleted the ph/maxInFlightRequests branch February 6, 2025 03:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 366 ms (+42.78% 🔺) 1.3 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 667 ms (+5.04% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 78 ms (+389.33% 🔺) 189 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (+783.1% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 136 ms (+133.16% 🔺) 521 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants