Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 6, 2025


PR-Codex overview

This PR focuses on enhancing the thirdweb package by adding a new FiatProvider option, optimizing button rendering in several screens, improving gas price handling, and refining error message management for better user feedback during transactions.

Detailed summary

  • Added "COINBASE" to FiatProvider type.
  • Simplified button rendering in FiatStatusScreen and SwapStatusScreen.
  • Refined transaction request handling in ConfirmationScreen to manage gas prices locally.
  • Implemented approval check in getQuote.ts.
  • Improved error message handling in BuyScreen and FiatScreen.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: f5b4fe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:41am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:41am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:41am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:41am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:41am

@joaquim-verges joaquim-verges marked this pull request as ready for review February 6, 2025 07:20
@joaquim-verges joaquim-verges requested review from a team as code owners February 6, 2025 07:20
@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch from d07de97 to f39e0ab Compare February 6, 2025 07:21
const data: BuyWithCryptoQuoteRouteResponse = (await response.json())
.result;

// check if the fromAddress already has approval for the given amoutn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: amoutn should be amount. Consider using a spell checker to catch these small issues before committing.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (+0.18% 🔺) 934 ms (+0.18% 🔺) 1.8 s (+96.42% 🔺) 2.8 s
thirdweb (cjs) 122.56 KB (+0.15% 🔺) 2.5 s (+0.15% 🔺) 3.1 s (-8.12% 🔽) 5.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 84 ms (-50.47% 🔽) 196 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (-9.29% 🔽) 38 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 338 ms (+9.46% 🔺) 724 ms

@joaquim-verges joaquim-verges merged commit f77165e into main Feb 6, 2025
26 of 30 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch February 6, 2025 08:36
@joaquim-verges joaquim-verges mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants