Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 6, 2025

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.

-->


PR-Codex overview

This PR updates the UsageV2Source type in the service-utils package to include additional source options and removes a duplicate getTopicName function.

Detailed summary

  • Modified UsageV2Source type to include: "bundler", "engine", "insight", "nebula", and "rpc".
  • Removed duplicate getTopicName function implementation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 6, 2025 09:39
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: fe449dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 9:39am
login 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 9:39am
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 9:39am
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 9:39am
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 9:39am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 597 ms (-6.34% 🔽) 1.6 s
thirdweb (cjs) 122.56 KB (0%) 2.5 s (0%) 1.1 s (-10.16% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 126 ms (+40.33% 🔺) 237 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 43 ms (+16.49% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 174 ms (+18.82% 🔺) 559 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants