Skip to content

Conversation

@jcheese1
Copy link

@jcheese1 jcheese1 commented Feb 7, 2025


PR-Codex overview

This PR introduces new chain definitions for treasure and treasureTopaz, updates the chain identification logic, and exports the new chains for use in the project.

Detailed summary

  • Added new chain definitions for treasure and treasureTopaz in packages/thirdweb/src/chains/chain-definitions/.
  • Updated chain identification logic in packages/thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts.
  • Exported new chains in packages/thirdweb/src/exports/chains.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jcheese1 jcheese1 requested review from a team as code owners February 7, 2025 09:47
@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 0fe4a3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2025

@jcheese1 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 7, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@joaquim-verges
Copy link
Member

@jcheese1 looks good! could you add a changeset if possible?

pnpm changeset from the root of the repo, hit enter until you can enter your changeset message (should be a patch change)

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.12%. Comparing base (64d7bf3) to head (0fe4a3c).
Report is 33 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (64d7bf3) and HEAD (0fe4a3c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (64d7bf3) HEAD (0fe4a3c)
packages 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6191       +/-   ##
===========================================
- Coverage   56.88%   42.12%   -14.76%     
===========================================
  Files        1155     1161        +6     
  Lines       63988    64200      +212     
  Branches     5193     3818     -1375     
===========================================
- Hits        36399    27046     -9353     
- Misses      26862    36453     +9591     
+ Partials      727      701       -26     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 55659be
packages 37.32% <100.00%> (-17.76%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../thirdweb/src/chains/chain-definitions/treasure.ts 100.00% <100.00%> (ø)
...dweb/src/chains/chain-definitions/treasureTopaz.ts 100.00% <100.00%> (ø)
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts 81.25% <100.00%> (-9.38%) ⬇️

... and 282 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 66bbedb into thirdweb-dev:main Feb 11, 2025
27 of 32 checks passed
@joaquim-verges joaquim-verges mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants