Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 7, 2025


PR-Codex overview

This PR introduces enhancements to the thirdweb package, focusing on allowing users to edit payment amounts mid-flow and improving error handling for price quotes.

Detailed summary

  • Added ApiError type and getErrorMessage function for better error handling.
  • Implemented editing pay amount functionality in FiatScreenContent and SwapScreenContent.
  • Improved UI components for fee and provider selection.
  • Refactored BuyScreen to utilize FiatScreenContent and SwapScreenContent.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 6ec60f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:46am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:46am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:46am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:46am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:46am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 7, 2025
Copy link
Member Author

joaquim-verges commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 346 ms (+20.55% 🔺) 1.3 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 619 ms (+4.13% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 84 ms (+158.86% 🔺) 196 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (+9.97% 🔺) 17 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 146 ms (+76.09% 🔺) 532 ms

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 9.42408% with 519 lines in your changes missing coverage. Please review.

Project coverage is 56.78%. Comparing base (64d7bf3) to head (6ec60f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nnectWallet/screens/Buy/swap/SwapScreenContent.tsx 8.61% 244 Missing ⚠️
...nnectWallet/screens/Buy/fiat/FiatScreenContent.tsx 10.30% 209 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 7.93% 58 Missing ⚠️
packages/thirdweb/src/react/web/utils/errors.ts 20.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (9.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6192      +/-   ##
==========================================
- Coverage   56.88%   56.78%   -0.11%     
==========================================
  Files        1155     1160       +5     
  Lines       63988    64179     +191     
  Branches     5193     5195       +2     
==========================================
+ Hits        36399    36441      +42     
- Misses      26862    27010     +148     
- Partials      727      728       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 64d7bf3
packages 54.96% <9.42%> (-0.12%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/react/web/utils/errors.ts 20.00% <20.00%> (ø)
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 4.41% <7.93%> (+0.17%) ⬆️
...nnectWallet/screens/Buy/fiat/FiatScreenContent.tsx 10.30% <10.30%> (ø)
...nnectWallet/screens/Buy/swap/SwapScreenContent.tsx 8.61% <8.61%> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 30e13e6 into main Feb 7, 2025
32 of 34 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_feat_Add_editable_token_amount_input_to_buy_screen branch February 7, 2025 11:54
@joaquim-verges joaquim-verges mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants