-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Check bytecode prefix #6196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Merge activity
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6196 +/- ##
==========================================
- Coverage 56.77% 56.76% -0.01%
==========================================
Files 1161 1161
Lines 64259 64261 +2
Branches 5197 5197
==========================================
- Hits 36483 36479 -4
- Misses 27049 27053 +4
- Partials 727 729 +2
*This pull request uses carry forward flags. Click here to find out more.
|
TOOL-3245
PR-Codex overview
This PR focuses on updating the
codecov.ymlconfiguration to ignore specific paths and modifying thezkDeployContractfunction to ensure the bytecode has the correct prefix.Detailed summary
codecov.ymlto ignore:"**/contract/deployment/zksync/**""*/thirdweb/src/contract/deployment/zksync/zkDeployContract.ts"zkDeployContract:ensureBytecodePrefix.ensureBytecodePrefixto processoptions.bytecode.factoryDepsto use the newbytecodevariable instead ofoptions.bytecode.