Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Feb 7, 2025

TOOL-3245


PR-Codex overview

This PR focuses on updating the codecov.yml configuration to ignore specific paths and modifying the zkDeployContract function to ensure the bytecode has the correct prefix.

Detailed summary

  • Updated codecov.yml to ignore:
    • Paths matching "**/contract/deployment/zksync/**"
    • The specific file "*/thirdweb/src/contract/deployment/zksync/zkDeployContract.ts"
  • In zkDeployContract:
    • Added import for ensureBytecodePrefix.
    • Used ensureBytecodePrefix to process options.bytecode.
    • Updated factoryDeps to use the new bytecode variable instead of options.bytecode.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners February 7, 2025 16:04
@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:49pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:49pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:49pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:49pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:49pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: b3732a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 608 ms (+62.83% 🔺) 1.6 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 1.2 s (-3.44% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 49 ms (+32.28% 🔺) 161 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+127.08% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 141 ms (-9.54% 🔽) 527 ms

@kumaryash90 kumaryash90 added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Feb 7, 2025
Copy link
Member Author

Merge activity

  • Feb 7, 11:37 AM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.76%. Comparing base (c5dfad8) to head (2064463).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...src/contract/deployment/zksync/zkDeployContract.ts 25.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6196      +/-   ##
==========================================
- Coverage   56.77%   56.76%   -0.01%     
==========================================
  Files        1161     1161              
  Lines       64259    64261       +2     
  Branches     5197     5197              
==========================================
- Hits        36483    36479       -4     
- Misses      27049    27053       +4     
- Partials      727      729       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b3732a3
packages 54.94% <25.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...src/contract/deployment/zksync/zkDeployContract.ts 19.14% <25.00%> (+1.37%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants