Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 7, 2025

Closes TOOL-2991


PR-Codex overview

This PR introduces enhancements to the sidebar and documentation for the EcosystemWallet and InAppWallet, adding new API references, updating existing functionalities, and improving user experience for authentication methods.

Detailed summary

  • Added rpcOverrides example in page.mdx.
  • Updated sidebar.tsx to include "API Reference" and "Blockchain API".
  • Revised EcosystemWallet and InAppWallet documentation with new authentication methods.
  • Introduced SiweExternal and Backend wallet options.
  • Enhanced user guidance for linking accounts and authentication flows.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper requested review from a team as code owners February 7, 2025 20:57
@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: e50d77d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:12pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 7, 2025 9:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 7, 2025 9:12pm
thirdweb-www ⬜️ Skipped (Inspect) Feb 7, 2025 9:12pm
wallet-ui ⬜️ Skipped (Inspect) Feb 7, 2025 9:12pm

@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 7, 2025
Copy link
Member Author

0xFirekeeper commented Feb 7, 2025

Merge activity

  • Feb 7, 3:57 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 7, 4:03 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 7, 4:13 PM EST: A user merged this pull request with the Graphite merge queue.

@0xFirekeeper 0xFirekeeper added the Portal Involves changes to the Portal (docs) codebase. label Feb 7, 2025
@linear
Copy link

linear bot commented Feb 7, 2025

new List<NebulaChatMessage>
{
new("What's the address of vitalik.eth", NebulaChatRole.User),
new("The address of vitalik.eth is 0xd8dA6BF26964aF8E437eEa5e3616511D7G3a3298", NebulaChatRole.Assistant),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ethereum address contains an invalid character G in 0xd8dA6BF26964aF8E437eEa5e3616511D7G3a3298. The correct address for vitalik.eth is 0xd8dA6BF26964aF8E437eEa5e3616511D7A3a3298. This typo would cause the transaction to fail since Ethereum addresses must only contain hexadecimal characters (0-9, a-f).

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (7f3b91d) to head (e50d77d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6200   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5197     5197           
=======================================
  Hits        36479    36479           
  Misses      27053    27053           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7f3b91d
packages 54.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 519 ms (-0.29% 🔽) 1.5 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 1.2 s (-19.38% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 116 ms (+250.71% 🔺) 228 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (+59.96% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 236 ms (+79.32% 🔺) 622 ms

Closes TOOL-2991
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces enhancements to the `sidebar` structure and API documentation, adds new wallet authentication options, and refines existing content for clarity. It also includes new RPC overrides and updates to the `InAppWallet` and `EcosystemWallet` functionalities.

### Detailed summary
- Added `rpcOverrides` example to `page.mdx`.
- Updated `sidebar.tsx` to include "API Reference" and "Blockchain API" sections.
- Replaced "Blockchain API" with "Nebula AI" in `sidebar.tsx`.
- Enhanced `EcosystemWallet` and `InAppWallet` functionalities with new login options.
- Clarified documentation on wallet connections and authentication methods.
- Added examples for `SiweExternal` login process.
- Updated various sections in `page.mdx` for better clarity and detail.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the firekeeper/dotnet-unity-docs-update branch from 7f46976 to e50d77d Compare February 7, 2025 21:06
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 7, 2025 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 21:06 Inactive
@graphite-app graphite-app bot merged commit e50d77d into main Feb 7, 2025
33 checks passed
@graphite-app graphite-app bot deleted the firekeeper/dotnet-unity-docs-update branch February 7, 2025 21:13
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 7, 2025 21:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 7, 2025 21:13 Inactive
@vercel vercel bot temporarily deployed to Production – login February 7, 2025 21:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 7, 2025 21:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants