Skip to content

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Feb 8, 2025

closes TOOL-3351


PR-Codex overview

This PR introduces support for "Wallet Credentials" in the engine, allowing secure management and creation of wallet credentials for Circle wallets. It enhances the UI and backend to accommodate these new features.

Detailed summary

  • Added Wallet Credentials section in the sidebar.
  • Introduced Circle wallet type in backend wallet options.
  • Implemented WalletCredentialsSection component for managing credentials.
  • Created forms for credential creation and editing.
  • Updated configuration components to include Circle wallet settings.
  • Enhanced API interactions for wallet credential management.
  • Updated documentation to reflect new features and setup instructions for Circle wallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr d4mr requested review from a team as code owners February 8, 2025 01:19
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: b73fa4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 9:48am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 9:48am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 8, 2025 9:48am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 8, 2025 9:48am
wallet-ui ⬜️ Skipped (Inspect) Feb 8, 2025 9:48am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 600 ms (-23.52% 🔽) 1.6 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 1.4 s (+33.47% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 81 ms (+172.91% 🔺) 193 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (-42.09% 🔽) 24 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 85 ms (-8.36% 🔽) 471 ms

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.77%. Comparing base (cbfe9ec) to head (b73fa4b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6202   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5196     5196           
=======================================
  Hits        36483    36483           
  Misses      27050    27050           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cbfe9ec
packages 54.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@d4mr d4mr changed the title doc updates [docs-engine] updates for circle and wallet credentials Feb 8, 2025
@vercel vercel bot temporarily deployed to Preview – login February 8, 2025 06:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 8, 2025 06:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 06:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 06:39 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 8, 2025
@d4mr d4mr changed the title [docs-engine] updates for circle and wallet credentials [dashboard-engine] updates for circle and wallet credentials Feb 8, 2025
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 8, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 8, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 07:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 07:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 8, 2025 07:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 8, 2025 07:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 08:55 Inactive
Copy link
Contributor Author

d4mr commented Feb 8, 2025

Merge activity

  • Feb 8, 4:45 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 8, 4:45 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 8, 4:48 AM EST: A user merged this pull request with the Graphite merge queue.

closes TOOL-3351

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces support for managing Circle wallet credentials in the thirdweb Engine, enhancing the wallet management features by allowing users to create, update, and configure Circle wallet credentials.

### Detailed summary
- Added `Wallet Credentials` section in the sidebar.
- Introduced `Circle` wallet option in backend wallet configurations.
- Created new components for managing Circle wallet credentials.
- Implemented credential creation and update functionalities.
- Updated UI components to support Circle wallet management.
- Enhanced documentation for Circle wallet setup and usage.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the pb/circle-wallets-and-credentials branch from a25efee to b73fa4b Compare February 8, 2025 09:45
@vercel vercel bot temporarily deployed to Preview – login February 8, 2025 09:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 09:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 09:45 Inactive
@graphite-app graphite-app bot merged commit b73fa4b into main Feb 8, 2025
32 checks passed
@graphite-app graphite-app bot deleted the pb/circle-wallets-and-credentials branch February 8, 2025 09:48
@vercel vercel bot temporarily deployed to Production – login February 8, 2025 09:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 8, 2025 09:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 8, 2025 09:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants