Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 10, 2025

PR-Codex overview

This PR focuses on fixing authentication for Cloudflare workers in the service-utils package by refining type definitions and updating how data is handled within the authorizeWorker function.

Detailed summary

  • Updated type definition of TeamAndProjectCacheWithPossibleTTL to be exported.
  • Added TeamAndProjectCacheWithPossibleTTL import in index.ts.
  • Changed parameter name from data to teamAndProjectResponse in the put function.
  • Modified the data structure passed to kvStore.put to use teamAndProjectResponse.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 10, 2025 15:50
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 57c4e2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:51pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:51pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:51pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:51pm
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:51pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

updatedAt: Date.now(),
data,
}),
teamAndProjectResponse,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be named teamAndProjectResponse because that's the field being read from the cache.

@arcoraven arcoraven merged commit 91b0367 into main Feb 10, 2025
28 of 31 checks passed
@arcoraven arcoraven deleted the ph/fixAuthCache branch February 10, 2025 15:52
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (c86e13b) to head (57c4e2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6219   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c86e13b
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 206 ms (+24.91% 🔺) 1.2 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 392 ms (+20.71% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 103 ms (+340.25% 🔺) 215 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 25 ms (+287.58% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 124 ms (+225.77% 🔺) 509 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants