-
Notifications
You must be signed in to change notification settings - Fork 619
[service-utils] fix auth cache for cf workers #6219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 57c4e2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
| updatedAt: Date.now(), | ||
| data, | ||
| }), | ||
| teamAndProjectResponse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be named teamAndProjectResponse because that's the field being read from the cache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6219 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 1161 1161
Lines 64289 64289
Branches 5196 5196
=======================================
Hits 36468 36468
Misses 27095 27095
Partials 726 726
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
PR-Codex overview
This PR focuses on fixing authentication for Cloudflare workers in the
service-utilspackage by refining type definitions and updating how data is handled within theauthorizeWorkerfunction.Detailed summary
TeamAndProjectCacheWithPossibleTTLto be exported.TeamAndProjectCacheWithPossibleTTLimport inindex.ts.datatoteamAndProjectResponsein theputfunction.kvStore.putto useteamAndProjectResponse.