Skip to content

kv catch cache put in cf worker #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

kv catch cache put in cf worker #6230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb56d9
catch cache puts
nischitpra Feb 11, 2025
d34f84d
create changeset
nischitpra Feb 11, 2025
0a29213
update log to warn
nischitpra Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-rules-protect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/service-utils": patch
---

catch cache puts for auth in cf workers
32 changes: 18 additions & 14 deletions packages/service-utils/src/cf-worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,24 @@ export async function authorizeWorker(
get: async (clientId: string) => serviceConfig.kvStore.get(clientId),
put: (clientId: string, teamAndProjectResponse: TeamAndProjectResponse) =>
serviceConfig.ctx.waitUntil(
serviceConfig.kvStore.put(
clientId,
JSON.stringify({
updatedAt: Date.now(),
teamAndProjectResponse,
} satisfies TeamAndProjectCacheWithPossibleTTL),
{
expirationTtl:
serviceConfig.cacheTtlSeconds &&
serviceConfig.cacheTtlSeconds >= DEFAULT_CACHE_TTL_SECONDS
? serviceConfig.cacheTtlSeconds
: DEFAULT_CACHE_TTL_SECONDS,
},
),
serviceConfig.kvStore
.put(
clientId,
JSON.stringify({
updatedAt: Date.now(),
teamAndProjectResponse,
} satisfies TeamAndProjectCacheWithPossibleTTL),
{
expirationTtl:
serviceConfig.cacheTtlSeconds &&
serviceConfig.cacheTtlSeconds >= DEFAULT_CACHE_TTL_SECONDS
? serviceConfig.cacheTtlSeconds
: DEFAULT_CACHE_TTL_SECONDS,
},
)
.catch((e) => {
console.warn(e);
Copy link
Member

@jnsdls jnsdls Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, shouldn't the consumer handle this if they want?

}),
),
cacheTtlSeconds: serviceConfig.cacheTtlSeconds ?? DEFAULT_CACHE_TTL_SECONDS,
});
Expand Down
Loading