[SDK] feat: Add verifyClaim export and canClaim function #6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 159ffbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Playground
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| * @example | ||
| * ```ts | ||
| * import { decodeVerifyClaimResult } from "thirdweb/extensions/erc20"; | ||
| * const result = decodeVerifyClaimResultResult("..."); |
Contributor
There was a problem hiding this comment.
The example code shows decodeVerifyClaimResultResult but the actual function name is decodeVerifyClaimResult. The extra "Result" suffix should be removed from the example for accuracy.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
jnsdls
requested changes
Feb 12, 2025
jnsdls
reviewed
Feb 12, 2025
Contributor
size-limit report 📦
|
joaquim-verges
force-pushed
the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
from
b48ca59 to
486b8df
Compare
jnsdls
approved these changes
Feb 12, 2025
Member
jnsdls
left a comment
jnsdls
left a comment
There was a problem hiding this comment.
LGTM except for lint and test failures and the AI has some feedback for you, too
joaquim-verges
force-pushed
the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
from
486b8df to
8e573ec
Compare
joaquim-verges
force-pushed
the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
from
8e573ec to
8d4962a
Compare
joaquim-verges
force-pushed
the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
from
8d4962a to
0378f35
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6234 +/- ##
==========================================
+ Coverage 56.81% 56.90% +0.09%
==========================================
Files 1163 1166 +3
Lines 64342 64475 +133
Branches 5213 5224 +11
==========================================
+ Hits 36556 36692 +136
+ Misses 27057 27056 -1
+ Partials 729 727 -2
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
Fixes TOOL-3381
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on exposing the `canClaim` extension function for ERC20, ERC721, and ERC1155 drops, allowing for better claim verification and improving the overall functionality of the drops system.
### Detailed summary
- Added `canClaim` function to `erc20`, `erc721`, and `erc1155` extensions.
- Updated tests to include `canClaim` functionality.
- Modified JSON ABI files to include `verifyClaim` function.
- Adjusted gas values in tests.
- Enhanced error handling in `extract-error.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
from
0378f35 to
159ffbf
Compare
graphite-app
bot
deleted the
_SDK_feat_Add_verifyClaim_export_and_canClaim_function
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TOOL-3381
PR-Codex overview
This PR focuses on exposing the
canClaimfunction for ERC20, ERC721, and ERC1155 drops, enhancing the claim verification process. It includes updates to related tests and modifies contract ABIs to support the new function.Detailed summary
canClaimfunction toerc20,erc721, anderc1155extensions.verifyClaimfunction.drop20.test.ts,drop721.test.ts, anddrop1155.test.ts.FiatSteps.tsxto format text correctly.