Skip to content

[Pay] Fix: fix fiat value to 2 decimals #6243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
Merged

[Pay] Fix: fix fiat value to 2 decimals #6243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa6afd
fix: fix fiat value to 2 decimals
gregfromstl Feb 13, 2025
e89b560
changeset
gregfromstl Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-frogs-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix PayEmbed fiat values to 2 decimal places
4 changes: 3 additions & 1 deletion packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/FiatValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ export function FiatValue(
}

return cryptoToFiatQuery.data?.result ? (
<Text {...props}>${formatNumber(cryptoToFiatQuery.data.result, 2)}</Text>
<Text {...props}>
${formatNumber(cryptoToFiatQuery.data.result, 2).toFixed(2)}
Copy link
Member

@joaquim-verges joaquim-verges Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the 2 param inside formatNumber already does it?

Copy link
Contributor Author

@gregfromstl gregfromstl Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't, format number just rounds it but leaves off trailing zeros (it returns a number)

Copy link
Member

@joaquim-verges joaquim-verges Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see

</Text>
) : null;
}
Loading