Skip to content

Conversation

@beauwilliams
Copy link
Contributor

@beauwilliams beauwilliams commented Feb 13, 2025


PR-Codex overview

This PR removes the import of TokenPaymaster and smartWallet from thirdweb/wallets, indicating that these components are no longer in use.

Detailed summary

  • Removed the import statement for TokenPaymaster and smartWallet from thirdweb/wallets.
  • Added a comment indicating that the removed components "no longer exists".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Beau <[email protected]>
@beauwilliams beauwilliams requested review from a team as code owners February 13, 2025 00:55
@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 0d55427

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 13, 2025

@beauwilliams is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 13, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Comment on lines +26 to 27
//This no longer exists
import { TokenPaymaster, smartWallet } from "thirdweb/wallets";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since TokenPaymaster and smartWallet have been removed from thirdweb/wallets, both the import statement and the explanatory comment should be deleted. The code that follows will need to be updated to use the current implementation pattern for handling gas payments. Consider opening a separate PR to update the remaining code examples in this documentation.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

<TabsContent value="typescript">
```tsx
import { base, lisk, celo } from "thirdweb/chains";
//This no longer exists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym ? exports are still there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants