-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] fix: Prevent popup when using auth redirect mode #6246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Prevent popup when using auth redirect mode #6246
Conversation
🦋 Changeset detectedLatest commit: 18e49ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5a1f394 to
b5563ca
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (12.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
==========================================
- Coverage 56.87% 56.86% -0.01%
==========================================
Files 1166 1166
Lines 64522 64523 +1
Branches 5223 5221 -2
==========================================
- Hits 36699 36694 -5
- Misses 27095 27101 +6
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more.
|
b5563ca to
18e49ee
Compare

Fixes TOOL-3410
PR-Codex overview
This PR focuses on enhancing the authentication process in the
thirdwebwallet, specifically by introducing async handling for login methods and adding a Google login option.Detailed summary
authenticateWithRedirectandloginWithOauthRedirectto returnPromise<void>.loginWithOauthRedirectbefore proceeding.loginWithGooglefunction for Google authentication.