Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Feb 13, 2025


PR-Codex overview

This PR introduces a new feature for fetching users from in-app wallets and updates the API endpoint for wallet pregeneration. It enhances user management capabilities and improves documentation for these functionalities.

Detailed summary

  • Added a new entry in sidebar.tsx for "Fetch Users" with a link.
  • Updated the API endpoint in page.mdx for wallet pregeneration.
  • Enhanced get-users/page.mdx with:
    • Metadata for the "Get Users" page.
    • Instructions on fetching users via REST API.
    • Example curl command for fetching users.
    • Response format for the user objects.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 13, 2025 23:40
@linear
Copy link

linear bot commented Feb 13, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 39a5b5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 4:10am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 14, 2025 4:10am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 14, 2025 4:10am
thirdweb-www ⬜️ Skipped (Inspect) Feb 14, 2025 4:10am
wallet-ui ⬜️ Skipped (Inspect) Feb 14, 2025 4:10am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 13, 2025

## Example curl Command

Here's an example curl command to pregenerate a thirdweb wallet for the user `[email protected]`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example description refers to pregenerating wallets, but this endpoint is for fetching users. The text should be updated to: "Here's an example curl command to fetch users:"

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Here's an example curl command to pregenerate a thirdweb wallet for the user `[email protected]`:

```bash
curl -X POST 'https://in-app-wallet.thirdweb.com/api/v1/users?offset=200&limit=100' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTP method should be GET rather than POST since this endpoint is retrieving data rather than creating/modifying resources. The curl command should be:

curl -X GET 'https://in-app-wallet.thirdweb.com/api/v1/users?offset=200&limit=100'

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (6f381d7) to head (39a5b5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6255   +/-   ##
=======================================
  Coverage   56.86%   56.86%           
=======================================
  Files        1166     1166           
  Lines       64523    64523           
  Branches     5226     5226           
=======================================
  Hits        36694    36694           
  Misses      27101    27101           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6f381d7
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.6 s (+7.84% 🔺) 3.5 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 6.5 s (+35.64% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 389 ms (+50% 🔺) 501 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 151 ms (+415.08% 🔺) 161 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 451 ms (-41.14% 🔽) 837 ms


Once you have users connecting to your app through in-app wallets, you can fetch all users through our REST API:
```
https://in-app-wallet.thirdweb.com/api/v1/users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should probably add how to get a single user here

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 14, 2025
Copy link
Contributor Author

gregfromstl commented Feb 14, 2025

Merge activity

  • Feb 13, 11:07 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 13, 11:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 13, 11:11 PM EST: A user merged this pull request with the Graphite merge queue.

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the user experience by adding a new feature to fetch users through an API and updating the API endpoint for wallet pregeneration.

### Detailed summary
- Added a new menu item `Fetch Users` in `sidebar.tsx`.
- Updated the API endpoint in `page.mdx` for wallet pregeneration.
- Introduced documentation for fetching users via REST API in `get-users/page.mdx`.
- Provided example curl command and response format for the new feature.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-3409-docs-bulk-export-users branch from dfeb482 to 39a5b5c Compare February 14, 2025 04:08
@vercel vercel bot temporarily deployed to Preview – login February 14, 2025 04:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 14, 2025 04:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 14, 2025 04:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 14, 2025 04:08 Inactive
@graphite-app graphite-app bot merged commit 39a5b5c into main Feb 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3409-docs-bulk-export-users branch February 14, 2025 04:11
@vercel vercel bot temporarily deployed to Production – login February 14, 2025 04:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 14, 2025 04:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 14, 2025 04:11 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 14, 2025 04:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants