-
Notifications
You must be signed in to change notification settings - Fork 621
[Portal] Docs: Get Users Docs #6255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| ## Example curl Command | ||
|
|
||
| Here's an example curl command to pregenerate a thirdweb wallet for the user `[email protected]`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example description refers to pregenerating wallets, but this endpoint is for fetching users. The text should be updated to: "Here's an example curl command to fetch users:"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| Here's an example curl command to pregenerate a thirdweb wallet for the user `[email protected]`: | ||
|
|
||
| ```bash | ||
| curl -X POST 'https://in-app-wallet.thirdweb.com/api/v1/users?offset=200&limit=100' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HTTP method should be GET rather than POST since this endpoint is retrieving data rather than creating/modifying resources. The curl command should be:
curl -X GET 'https://in-app-wallet.thirdweb.com/api/v1/users?offset=200&limit=100'Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6255 +/- ##
=======================================
Coverage 56.86% 56.86%
=======================================
Files 1166 1166
Lines 64523 64523
Branches 5226 5226
=======================================
Hits 36694 36694
Misses 27101 27101
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
|
|
||
| Once you have users connecting to your app through in-app wallets, you can fetch all users through our REST API: | ||
| ``` | ||
| https://in-app-wallet.thirdweb.com/api/v1/users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we should probably add how to get a single user here
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the user experience by adding a new feature to fetch users through an API and updating the API endpoint for wallet pregeneration.
### Detailed summary
- Added a new menu item `Fetch Users` in `sidebar.tsx`.
- Updated the API endpoint in `page.mdx` for wallet pregeneration.
- Introduced documentation for fetching users via REST API in `get-users/page.mdx`.
- Provided example curl command and response format for the new feature.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
dfeb482 to
39a5b5c
Compare
PR-Codex overview
This PR introduces a new feature for fetching users from in-app wallets and updates the API endpoint for wallet pregeneration. It enhances user management capabilities and improves documentation for these functionalities.
Detailed summary
sidebar.tsxfor "Fetch Users" with a link.page.mdxfor wallet pregeneration.get-users/page.mdxwith: