Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Feb 14, 2025


PR-Codex overview

This PR enhances the PlanInfoCard component in the billing settings of the dashboard. It improves the layout and adds a new informational paragraph about managing billing.

Detailed summary

  • Changed the layout of the first <div> from row to column alignment.
  • Added a new <p> element with instructions for managing billing.
  • Updated the variant prop of the BillingPortalButton from outline to primary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi added the Dashboard Involves changes to the Dashboard. label Feb 14, 2025
@GiselleNessi GiselleNessi self-assigned this Feb 14, 2025
@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:03pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 24, 2025 7:03pm
login ⬜️ Skipped (Inspect) Feb 24, 2025 7:03pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 24, 2025 7:03pm
wallet-ui ⬜️ Skipped (Inspect) Feb 24, 2025 7:03pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: e1e171b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.85%. Comparing base (e201e3d) to head (e1e171b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6258   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files        1166     1166           
  Lines       64526    64526           
  Branches     5223     5223           
=======================================
  Hits        36686    36686           
  Misses      27115    27115           
  Partials      725      725           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e201e3d
packages 55.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.25 KB (-0.11% 🔽) 925 ms (-0.11% 🔽) 270 ms (-22.01% 🔽) 1.2 s
thirdweb (cjs) 121.87 KB (0%) 2.5 s (0%) 849 ms (+10.7% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 126 ms (+344.93% 🔺) 238 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (+45.08% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 156 ms (+156.92% 🔺) 541 ms

@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 14, 2025
@GiselleNessi GiselleNessi marked this pull request as ready for review February 14, 2025 13:45
@GiselleNessi GiselleNessi requested review from a team as code owners February 14, 2025 13:45
Copy link
Contributor Author

GiselleNessi commented Feb 14, 2025

Merge activity

  • Feb 14, 8:46 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 24, 1:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 24, 1:59 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `PlanInfoCard` component in the billing settings of the dashboard. It enhances the layout and adds informative text to improve user experience.

### Detailed summary
- Changed the inner `div` from `flex items-center` to `flex flex-col items-start`.
- Added a new paragraph with instructions for managing billing.
- Updated the `variant` prop of the `BillingPortalButton` from `outline` to `primary`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the gi/update-billing-management-text branch from e1e171b to a0f6b47 Compare February 24, 2025 18:55
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 24, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 24, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 24, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 24, 2025 18:55 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Feb 24, 2025
@jnsdls jnsdls merged commit 454fc6a into main Feb 25, 2025
29 of 30 checks passed
@jnsdls jnsdls deleted the gi/update-billing-management-text branch February 25, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants