Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Feb 14, 2025


PR-Codex overview

This PR primarily focuses on removing references to Discord from various components and documentation, simplifying the code and potentially reducing reliance on the Discord platform.

Detailed summary

  • Removed Discord badge and link from README.md and packages/thirdweb/README.md.
  • Eliminated DiscordIcon usage from apps/dashboard/src/components/footer/socialLinks.tsx and apps/dashboard/src/@/components/blocks/app-footer.tsx.
  • Deleted Discord community card and related content from apps/dashboard/src/app/(dashboard)/support/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Feb 14, 2025
@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 58288e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:37pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:37pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:37pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:37pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:37pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Feb 14, 2025
@GiselleNessi GiselleNessi removed packages SDK Involves changes to the thirdweb SDK labels Feb 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.6 s (+11.13% 🔺) 3.5 s
thirdweb (cjs) 121.87 KB (0%) 2.5 s (0%) 5.8 s (+7.65% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 293 ms (+133.57% 🔺) 405 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (-55.36% 🔽) 42 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 636 ms (+38.06% 🔺) 1.1 s

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (e201e3d) to head (0b28fd9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6259      +/-   ##
==========================================
+ Coverage   56.85%   56.87%   +0.02%     
==========================================
  Files        1166     1166              
  Lines       64526    64526              
  Branches     5223     5227       +4     
==========================================
+ Hits        36686    36700      +14     
+ Misses      27115    27098      -17     
- Partials      725      728       +3     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e201e3d
packages 55.08% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor Author

GiselleNessi commented Feb 14, 2025

Merge activity

  • Feb 14, 8:45 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 24, 10:31 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants