Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 16, 2025


PR-Codex overview

This PR focuses on improving the UI components and logic related to payment options in a wallet connection context, specifically for fiat and crypto transactions. It enhances usability by refining text, adding error handling, and optimizing component imports.

Detailed summary

  • Updated Text components to have consistent sizes.
  • Enhanced error handling in fetchAllBlueprints.
  • Changed WalletRow import path for consistency.
  • Updated TransactionModeScreen to remove unused sources.
  • Improved token selection logic in TokenSelectorScreen.
  • Added functionality to handle payment with credit cards.
  • Refined UI in various components for better user experience.
  • Improved handling of wallet connections and balances.
  • Streamlined conditional rendering for token and chain selections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: f5f00bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Feb 17, 2025 2:32am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:32am

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.7 s (+13.08% 🔺) 3.7 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 4.4 s (-7.2% 🔽) 6.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 292 ms (+142.43% 🔺) 404 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (-0.92% 🔽) 38 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 782 ms (+14.52% 🔺) 1.2 s

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 8.00821% with 448 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (0574eac) to head (f5f00bb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ectWallet/screens/Buy/swap/TokenSelectorScreen.tsx 5.50% 103 Missing ⚠️
.../ui/ConnectWallet/screens/Buy/swap/SwapSummary.tsx 6.79% 96 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 1.47% 67 Missing ⚠️
...nnectWallet/screens/Buy/swap/SwapScreenContent.tsx 0.00% 49 Missing ⚠️
...eb/ui/ConnectWallet/screens/Buy/swap/WalletRow.tsx 21.05% 45 Missing ⚠️
...web/src/react/web/ui/components/token/TokenRow.tsx 3.33% 29 Missing ⚠️
...i/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx 4.54% 21 Missing ⚠️
...nectWallet/screens/Buy/swap/ConfirmationScreen.tsx 15.00% 17 Missing ⚠️
...et/screens/Buy/swap/TransferConfirmationScreen.tsx 11.76% 15 Missing ⚠️
...ectWallet/screens/Buy/main/useUISelectionStates.ts 0.00% 3 Missing ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (8.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6268      +/-   ##
==========================================
- Coverage   56.87%   56.85%   -0.02%     
==========================================
  Files        1166     1168       +2     
  Lines       64629    64657      +28     
  Branches     5242     5238       -4     
==========================================
+ Hits        36755    36760       +5     
- Misses      27146    27169      +23     
  Partials      728      728              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0574eac
packages 55.06% <8.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 9.65% <100.00%> (ø)
.../react/web/ui/ConnectWallet/screens/nativeToken.ts 72.22% <100.00%> (+3.47%) ⬆️
...nnectWallet/screens/Buy/fiat/FiatScreenContent.tsx 10.21% <0.00%> (-0.05%) ⬇️
...nectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx 13.54% <0.00%> (ø)
...act/web/ui/ConnectWallet/screens/TokenSelector.tsx 8.72% <0.00%> (ø)
...ectWallet/screens/Buy/main/useUISelectionStates.ts 8.91% <0.00%> (+0.87%) ⬆️
...et/screens/Buy/swap/TransferConfirmationScreen.tsx 10.69% <11.76%> (+0.09%) ⬆️
...nectWallet/screens/Buy/swap/ConfirmationScreen.tsx 9.58% <15.00%> (+1.05%) ⬆️
...i/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx 14.28% <4.54%> (-2.62%) ⬇️
...web/src/react/web/ui/components/token/TokenRow.tsx 13.86% <3.33%> (-3.22%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch from f368199 to e8bf20a Compare February 16, 2025 10:44
@joaquim-verges joaquim-verges marked this pull request as ready for review February 16, 2025 10:46
@joaquim-verges joaquim-verges requested review from a team as code owners February 16, 2025 10:46
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch from e8bf20a to a56b170 Compare February 16, 2025 10:49
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch from a56b170 to 99535ba Compare February 16, 2025 11:06
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch from 99535ba to 4e37cc8 Compare February 17, 2025 00:35
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch 2 times, most recently from d35fb5b to bee8c57 Compare February 17, 2025 01:58
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Redesign_token_selection_flow_in_PayEmbed branch from bee8c57 to f2cbb39 Compare February 17, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants