Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 17, 2025

PR-Codex overview

This PR focuses on restructuring the project files by moving various components from the team_slug and project_slug directories to an (internal) directory. This change aims to organize the codebase and improve maintainability.

Detailed summary

  • Moved multiple components and files from team_slug and project_slug to (internal) subdirectories.
  • Updated import paths to reflect the new file locations.
  • Adjusted sorting logic in ManageMembersSection for date comparison.
  • Added a new function service_getTeamBySlug to fetch team details using an API key.
  • Modified various settings and layout files to ensure they point to the correct internal paths.

The following files were skipped due to too many changes: apps/dashboard/src/app/team/[team_slug]/[project_slug]/nebula/components/analytics/nebula-analytics-filter.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/account-abstraction/settings/page.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/_components/TransactionsCard.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/_components/TotalSponsoredCard.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/engine/(instance)/[engineId]/layout.tsx, apps/dashboard/src/@/actions/acceptInvite.ts, apps/dashboard/src/app/team/[team_slug]/[project_slug]/components/Transactions/TransactionCharts.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/page.tsx, apps/dashboard/src/app/team/[team_slug]/join/[invite_id]/components/accept-invite-card.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/analytics/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/account-abstraction/factories/page.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/members/InviteSection.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: 56462b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 5:50am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 17, 2025 5:50am
login ⬜️ Skipped (Inspect) Feb 17, 2025 5:50am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 17, 2025 5:50am
wallet-ui ⬜️ Skipped (Inspect) Feb 17, 2025 5:50am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 17, 2025 05:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 17, 2025 05:08 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 17, 2025 05:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 17, 2025 05:08 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 17, 2025
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 17, 2025 — with Graphite App
Copy link
Member Author

jnsdls commented Feb 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls added the BLOCKED label Feb 17, 2025 — with Graphite App
@jnsdls jnsdls marked this pull request as ready for review February 17, 2025 05:08
@jnsdls jnsdls requested review from a team as code owners February 17, 2025 05:08
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.85%. Comparing base (a258e7e) to head (56462b5).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6271   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files        1168     1168           
  Lines       64657    64657           
  Branches     5238     5238           
=======================================
  Hits        36760    36760           
  Misses      27169    27169           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a258e7e
packages 55.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@jnsdls jnsdls force-pushed the 02-16-enable_team_invites branch from 3bf9042 to bb58bbb Compare February 17, 2025 05:11
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 17, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 17, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 17, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 17, 2025 05:11 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.6 s (+20.64% 🔺) 3.5 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 7 s (+27.05% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 251 ms (-16.56% 🔽) 363 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 211 ms (+468.92% 🔺) 221 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 849 ms (+59.33% 🔺) 1.3 s

@jnsdls jnsdls force-pushed the 02-16-enable_team_invites branch from bb58bbb to 56462b5 Compare February 17, 2025 05:43
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 17, 2025 05:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 17, 2025 05:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 17, 2025 05:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 17, 2025 05:43 Inactive
@jnsdls jnsdls closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLOCKED Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants