-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] bytes32 salt for deterministic deployment #6274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] bytes32 salt for deterministic deployment #6274
Conversation
🦋 Changeset detectedLatest commit: 22a95a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6274 +/- ##
==========================================
+ Coverage 56.84% 56.85% +0.01%
==========================================
Files 1168 1168
Lines 64662 64677 +15
Branches 5235 5246 +11
==========================================
+ Hits 36755 36772 +17
+ Misses 27179 27177 -2
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more.
|
TOOL-3443
PR-Codex overview
This PR focuses on enhancing the handling of
saltvalues for deterministic contract deployments in thethirdwebpackage, ensuring thatsaltvalues are validated as hex strings and updating related functions and tests.Detailed summary
saltin multiple files to validate if it's a hex string of length 66.computeDeploymentAddress,getInitBytecodeWithSalt, andzkDeployContractDeterministicto use the newsaltlogic.