Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 18, 2025


PR-Codex overview

This PR focuses on updating the PayEmbed functionality to respect the supportedTokensOverrides parameter in the createSupportedTokens function, allowing custom token lists to be returned when provided.

Detailed summary

  • Added handling for supportedTokensOverrides in createSupportedTokens function.
  • If supportedTokensOverrides is provided, it directly returns this list instead of constructing a default token list.
  • Removed the previous logic that merged supportedTokensOverrides into the default tokens.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:59am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:59am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:59am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:59am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:59am

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: e0ffa40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.9 s (+15.29% 🔺) 3.8 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 4.6 s (-26.94% 🔽) 7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 155 ms (-35.9% 🔽) 267 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (-10.25% 🔽) 38 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 559 ms (+51.95% 🔺) 945 ms

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.84%. Comparing base (b182302) to head (e0ffa40).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6283      +/-   ##
==========================================
- Coverage   56.85%   56.84%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       64677    64787     +110     
  Branches     5246     5262      +16     
==========================================
+ Hits        36772    36829      +57     
- Misses      27177    27230      +53     
  Partials      728      728              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b182302
packages 55.06% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 4.54% <0.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 5a08176 into main Feb 18, 2025
34 of 38 checks passed
@joaquim-verges joaquim-verges deleted the _thirdweb_fix_Respect_supportedTokens_override_in_PayEmbed branch February 18, 2025 05:04
@joaquim-verges joaquim-verges mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants