Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Feb 18, 2025

TOOL-3458


PR-Codex overview

This PR introduces a new gas price configuration for a blockchain network named Ronin, enhancing the CUSTOM_GAS_BINS with a specific entry for the year 2020.

Detailed summary

  • Added a new entry for 2020 in the gas price configuration.
  • Set the name to "Ronin".
  • Defined the gasPrice for Ronin as 110n * 10n ** 9n.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners February 18, 2025 17:26
@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: d4a49b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 9:30pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 9:30pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 9:30pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 9:30pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 9:30pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 18, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 1.6 s (+90.63% 🔺) 2.5 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 2.2 s (-10.2% 🔽) 4.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 152 ms (+58.44% 🔺) 264 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 39 ms (-19.27% 🔽) 49 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 250 ms (-7.92% 🔽) 636 ms

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (35b7a0e) to head (d4a49b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6286      +/-   ##
==========================================
- Coverage   56.83%   56.83%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       64789    64793       +4     
  Branches     5259     5260       +1     
==========================================
- Hits        36825    36824       -1     
- Misses      27237    27242       +5     
  Partials      727      727              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 35b7a0e
packages 55.04% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../src/contract/deployment/utils/create-2-factory.ts 89.31% <100.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

@kumaryash90 kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 18, 2025
@kumaryash90 kumaryash90 changed the title Custom create2 gas config update [SDK] fix: Custom create2 gas config update Feb 18, 2025
Copy link
Member Author

kumaryash90 commented Feb 18, 2025

Merge activity

  • Feb 18, 4:27 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 18, 4:27 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 18, 4:31 PM EST: A user merged this pull request with the Graphite merge queue.

TOOL-3458

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new gas price configuration for a blockchain network named `Ronin` within the `create-2-factory.ts` file.

### Detailed summary
- Added a new entry for the year `"2020"` with:
  - `name`: `"Ronin"`
  - `gasPrice`: `110n * 10n ** 9n`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants