-
Notifications
You must be signed in to change notification settings - Fork 619
[thirdweb] fix: Respect buyWithFiat setting in PayEmbed #6289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thirdweb] fix: Respect buyWithFiat setting in PayEmbed #6289
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 01c23ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
26af60d to
01c23ec
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
==========================================
- Coverage 56.84% 56.84% -0.01%
==========================================
Files 1168 1168
Lines 64787 64789 +2
Branches 5262 5259 -3
==========================================
- Hits 36829 36828 -1
- Misses 27230 27233 +3
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more.
|

PR-Codex overview
This PR focuses on respecting the
buyWithFiatoption in the payment embed, ensuring that the option to pay with fiat is only available when explicitly supported.Detailed summary
TokenSelectorScreento include a new propfiatSupported.fiatSupportedprop.fiatSupportedis true.