Skip to content

[thirdweb] fix: Respect buyWithFiat setting in PayEmbed #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[thirdweb] fix: Respect buyWithFiat setting in PayEmbed #6289

merged 1 commit into from
Feb 18, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 18, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on respecting the buyWithFiat option in the payment embed, ensuring that the option to pay with fiat is only available when explicitly supported.

Detailed summary

  • Updated TokenSelectorScreen to include a new prop fiatSupported.
  • Conditional rendering of the "Pay with credit card" button based on the fiatSupported prop.
  • Removed the always rendered button for paying with fiat, now it only appears if fiatSupported is true.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🛑 Canceled (Inspect) Feb 18, 2025 6:31pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:31pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:31pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:31pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:31pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 01c23ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 18, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review February 18, 2025 18:19
@joaquim-verges joaquim-verges requested review from a team as code owners February 18, 2025 18:19
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Feb 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _thirdweb_fix_Respect_buyWithFiat_setting_in_PayEmbed branch from 26af60d to 01c23ec Compare February 18, 2025 18:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 382 ms (+61.43% 🔺) 1.4 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 774 ms (+17.35% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 55 ms (+54.76% 🔺) 167 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 38 ms (+431.06% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 106 ms (+48.74% 🔺) 492 ms

@joaquim-verges joaquim-verges merged commit 5abbae7 into main Feb 18, 2025
28 of 31 checks passed
@joaquim-verges joaquim-verges deleted the _thirdweb_fix_Respect_buyWithFiat_setting_in_PayEmbed branch February 18, 2025 18:28
@joaquim-verges joaquim-verges mentioned this pull request Feb 18, 2025
Merged
@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.84%. Comparing base (5a08176) to head (01c23ec).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ectWallet/screens/Buy/swap/TokenSelectorScreen.tsx 0.00% 21 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6289      +/-   ##
==========================================
- Coverage   56.84%   56.84%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       64787    64789       +2     
  Branches     5262     5259       -3     
==========================================
- Hits        36829    36828       -1     
- Misses      27230    27233       +3     
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5a08176
packages 55.05% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 4.53% <0.00%> (-0.01%) ⬇️
...ectWallet/screens/Buy/swap/TokenSelectorScreen.tsx 6.58% <0.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges