Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 18, 2025


PR-Codex overview

This PR primarily focuses on the onboarding process and related UI components, enhancing the user experience for account creation, email verification, and team information collection. It also removes unused components and refines existing functionalities.

Detailed summary

  • Deleted unused files related to onboarding.
  • Added storybookLog function for custom logging in Storybook.
  • Introduced newAccountStub for account data stubbing.
  • Removed <Toaster richColors /> from multiple story files.
  • Updated validation schemas for email handling.
  • Created new onboarding components like OnboardingCard and ConnectEmbedSizedLoadingCard.
  • Enhanced LoginOrSignup and TeamInfoOnboarding with new form handling.
  • Implemented VerifyEmail and LinkWalletVerifyEmail components for email verification processes.
  • Improved error handling and user feedback with toasts in various components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 18, 2025

@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:53pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 18, 2025 10:53pm
login ⬜️ Skipped (Inspect) Feb 18, 2025 10:53pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 18, 2025 10:53pm
wallet-ui ⬜️ Skipped (Inspect) Feb 18, 2025 10:53pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 22:45 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: b80ae7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 22:45 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 18, 2025 22:45
@MananTank MananTank requested review from a team as code owners February 18, 2025 22:45
@MananTank MananTank changed the title temp [TOOL-3446] Dashboard: Remove /v1/keys usage Feb 18, 2025
@MananTank MananTank closed this Feb 18, 2025
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (52cbcd2) to head (b80ae7a).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6292      +/-   ##
==========================================
- Coverage   56.87%   56.83%   -0.05%     
==========================================
  Files        1166     1168       +2     
  Lines       64612    64793     +181     
  Branches     5248     5260      +12     
==========================================
+ Hits        36747    36824      +77     
- Misses      27137    27242     +105     
+ Partials      728      727       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 52cbcd2
packages 55.04% <ø> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 27 files with indirect coverage changes

@MananTank MananTank changed the title [TOOL-3446] Dashboard: Remove /v1/keys usage Remove /v1/keys usage Feb 18, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 3.2 s (+21.99% 🔺) 4.1 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.4 s (-6.14% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 390 ms (+97.33% 🔺) 502 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 57 ms (-29.04% 🔽) 67 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 623 ms (-58.05% 🔽) 1.1 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants