-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Fix: Upload storage timeout #6300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Upload storage timeout #6300
Conversation
🦋 Changeset detectedLatest commit: 7d776eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6300 +/- ##
==========================================
- Coverage 56.83% 56.82% -0.02%
==========================================
Files 1168 1168
Lines 64793 64794 +1
Branches 5260 5258 -2
==========================================
- Hits 36824 36817 -7
- Misses 27242 27251 +9
+ Partials 727 726 -1
*This pull request uses carry forward flags. Click here to find out more.
|
PR-Codex overview
This PR focuses on fixing the storage upload timeout in the
thirdwebpackage by allowing the timeout to be configurable through client settings.Detailed summary
requestTimeoutMsinweb-node.tsto useclient.config?.storage?.fetch?.requestTimeoutMs.mobile.tsto default toclient.config?.storage?.fetch?.requestTimeoutMsor 30000 if not set.