Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Feb 19, 2025


PR-Codex overview

This PR focuses on fixing the storage upload timeout in the thirdweb package by allowing the timeout to be configurable through client settings.

Detailed summary

  • Updated requestTimeoutMs in web-node.ts to use client.config?.storage?.fetch?.requestTimeoutMs.
  • Modified the timeout in mobile.ts to default to client.config?.storage?.fetch?.requestTimeoutMs or 30000 if not set.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 19, 2025 18:43
@linear
Copy link

linear bot commented Feb 19, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 7d776eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:52pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:52pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:52pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:52pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 19, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.3 s (-25.26% 🔽) 3.2 s
thirdweb (cjs) 121.87 KB (-0.02% 🔽) 2.5 s (-0.02% 🔽) 6 s (+15.87% 🔺) 8.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 374 ms (+79.75% 🔺) 486 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 192 ms (+358.06% 🔺) 202 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 504 ms (-54.77% 🔽) 890 ms

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.82%. Comparing base (45ac0cb) to head (7d776eb).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/storage/upload/web-node.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6300      +/-   ##
==========================================
- Coverage   56.83%   56.82%   -0.02%     
==========================================
  Files        1168     1168              
  Lines       64793    64794       +1     
  Branches     5260     5258       -2     
==========================================
- Hits        36824    36817       -7     
- Misses      27242    27251       +9     
+ Partials      727      726       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 45ac0cb
packages 55.03% <0.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/storage/upload/web-node.ts 91.83% <0.00%> (-1.92%) ⬇️

... and 3 files with indirect coverage changes

@gregfromstl gregfromstl merged commit 2cb89cb into main Feb 24, 2025
32 of 33 checks passed
@gregfromstl gregfromstl deleted the greg/tool-3474-make-storage-timeouts-overridable branch February 24, 2025 05:26
@joaquim-verges joaquim-verges mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants