Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 20, 2025

PR-Codex overview

This PR updates the middleware logic for handling subdomains related to the nebula application. It allows for a broader range of subdomain formats, particularly for Vercel preview environments.

Detailed summary

  • Changed the condition to check for subdomain presence.
  • Allowed subdomains to match either nebula or any subdomain starting with nebula---.
  • Updated the path rewrite logic to accommodate the new subdomain formats.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 9:32pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 9:32pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 9:32pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 9:32pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 9:32pm

@linear
Copy link

linear bot commented Feb 20, 2025

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 20, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 20, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 20, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 20, 2025 11:55 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 733c1e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 20, 2025
@MananTank MananTank marked this pull request as ready for review February 20, 2025 11:55
@MananTank MananTank requested a review from a team as a code owner February 20, 2025 11:55
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank requested a review from a team as a code owner February 20, 2025 11:55
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (439485b) to head (733c1e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6303   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 439485b
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title [TOOL-3483] Dashboard: Fix Nebula subdomain rewrite in Vercel preview links [TOOL-3483] Dashboard: Fix Nebula subdomain rewrite for Vercel preview links Feb 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 393 ms (+17.18% 🔺) 1.4 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 730 ms (-3.84% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 197 ms (+856.72% 🔺) 308 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 30 ms (+131.38% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 184 ms (+98.97% 🔺) 569 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 20, 2025 11:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 20, 2025 11:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 20, 2025 11:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 20, 2025 11:59 Inactive
@MananTank MananTank marked this pull request as draft February 20, 2025 12:02
@MananTank MananTank marked this pull request as ready for review February 20, 2025 12:18
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 20, 2025

Merge activity

…w links (#6303)

<!-- start pr-codex -->

## PR-Codex overview
This PR updates the middleware logic to handle subdomains more flexibly, accommodating both the standard `nebula` subdomain and a new format used in Vercel previews.

### Detailed summary
- Changed the condition to check for `subdomain` being either `nebula` or starting with `nebula---`.
- Updated the path rewriting logic to prepend `nebula-app` to the existing paths when the condition is met.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants