Skip to content

[TOOL-3493] Dashboard: Fix search in team members page, minor ui tweaks #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

[TOOL-3493] Dashboard: Fix search in team members page, minor ui tweaks #6309

merged 1 commit into from
Feb 21, 2025
+38 −14

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 21, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the member management functionality by adding search capabilities to filter team members and invites based on a search term. It introduces new state management for search and updates relevant components to utilize this feature.

Detailed summary

  • Added searchTerm, setSearchTerm, and searchPlaceholder to relevant components.
  • Implemented search filtering in ManageInvitesSection and ManageMembersSection.
  • Updated Input and Badge components to utilize new search functionality.
  • Modified MemberRow class for improved styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 4:19pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 4:19pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 4:19pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 4:19pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 4:19pm

@linear
Copy link

linear bot commented Feb 21, 2025

TOOL-3493 Fix search bar not working in team members page

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 21, 2025
@MananTank MananTank marked this pull request as ready for review February 21, 2025 15:50
@MananTank MananTank requested review from a team as code owners February 21, 2025 15:50
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (7775e7c) to head (035fcf6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6309   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7775e7c
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 035fcf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.5 s (+39.32% 🔺) 3.4 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.3 s (-21.72% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 334 ms (+40.55% 🔺) 446 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 79 ms (+103.82% 🔺) 89 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 614 ms (+30.06% 🔺) 999 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 21, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3493] Dashboard: Fix search in team members page, minor ui twea…
035fcf6 
…ks (#6309)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the member management functionality by adding search capabilities to filter team members and invites based on a search term. It introduces new state variables and updates components to utilize these features.

### Detailed summary
- Added `searchTerm`, `setSearchTerm`, and `searchPlaceholder` to relevant components.
- Updated the `Input` component to use `searchTerm` and `setSearchTerm`.
- Implemented filtering logic for invites and members based on `searchTerm`.
- Replaced `GradientAvatar` with `Badge` in `TeamSettingsSidebar`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot merged commit 035fcf6 into main Feb 21, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3493 branch February 21, 2025 16:20
@vercel vercel bot temporarily deployed to Production – docs-v2 February 21, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 21, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 21, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Production – login February 21, 2025 16:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls