Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 24, 2025

closes: CORE-748


PR-Codex overview

This PR focuses on updating the analytics data handling in the application, transitioning from using clientId and accountId to teamId and projectId. It also enhances error handling and modifies API endpoints to reflect these changes.

Detailed summary

  • Removed ANALYTICS_SERVICE_API_KEY from turbo.json.
  • Introduced AnalyticsQueryParamsV2 in analytics.ts.
  • Replaced clientId and accountId with teamId and projectId in various components and functions.
  • Updated API calls to use new endpoints (e.g., v2/wallets/connects).
  • Enhanced error handling with detailed logging.
  • Adjusted getEcosystemWalletUsage to include teamId and projectId as parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 24, 2025 18:28 Inactive
@vercel
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 8:45pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 8:45pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 8:45pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 8:45pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 8:45pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 24, 2025 18:28 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 9cc8979

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 24, 2025 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 24, 2025 18:28 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 24, 2025
Copy link
Member Author

jnsdls commented Feb 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review February 24, 2025 18:29
@jnsdls jnsdls requested review from a team as code owners February 24, 2025 18:29
@linear
Copy link

linear bot commented Feb 24, 2025

@jnsdls jnsdls force-pushed the migrate_analytics_endpoints_from_v1_to_v2 branch from 3945987 to 33084a7 Compare February 24, 2025 20:28
@vercel vercel bot temporarily deployed to Preview – login February 24, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 24, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 24, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 24, 2025 20:28 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 1.1 s (-26.42% 🔽) 2 s
thirdweb (cjs) 121.87 KB (0%) 2.5 s (0%) 2.2 s (+1.24% 🔺) 4.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 82 ms (-26.38% 🔽) 193 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (-53.49% 🔽) 38 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 381 ms (+37.53% 🔺) 767 ms

@jnsdls jnsdls deleted the migrate_analytics_endpoints_from_v1_to_v2 branch February 24, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants