Skip to content

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Feb 27, 2025

PR-Codex overview

This PR focuses on enhancing the predictAddress function with caching capabilities and adding new parameters to user operation functions for better control over deployment checks.

Detailed summary

  • Added caching to the predictAddress function using withCache.
  • Introduced isDeployedOverride parameter in createUnsignedUserOp and createAndSignUserOp functions.
  • Simplified deployment checks by removing redundant conditions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr d4mr requested review from a team as code owners February 27, 2025 14:31
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 5fc1d4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:13pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:13pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:13pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:13pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:13pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.64 KB (0%) 933 ms (0%) 176 ms (+195.02% 🔺) 1.2 s
thirdweb (cjs) 124.45 KB (-0.09% 🔽) 2.5 s (-0.09% 🔽) 211 ms (+41.77% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 77 ms (+774.18% 🔺) 189 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (+717.82% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 66 ms (+486.69% 🔺) 453 ms

@joaquim-verges joaquim-verges merged commit 2ec6cc0 into main Feb 27, 2025
28 of 30 checks passed
@joaquim-verges joaquim-verges deleted the pb/feat-smart-account-deployment-override branch February 27, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants