Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 3, 2025

PR-Codex overview

This PR focuses on removing several components related to the "Share Free Wallets" feature and refactoring the CouponCard component to simplify its functionality by eliminating unnecessary parameters and state management.

Detailed summary

  • Deleted multiple files related to the "Share Free Wallets" feature.
  • Removed the dynamic import of LazyShareFreeWalletsModal in CouponCard.tsx.
  • Simplified onCouponApplied function signature by removing the isFreeWalletsCoupon parameter.
  • Eliminated the state management for showShareModal.
  • Adjusted the CouponSection component to remove modal handling logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Mar 3, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: b5e02a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 1:54am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 4, 2025 1:54am
login ⬜️ Skipped (Inspect) Mar 4, 2025 1:54am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 4, 2025 1:54am
wallet-ui ⬜️ Skipped (Inspect) Mar 4, 2025 1:54am

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 22:56 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 3, 2025
@MananTank MananTank marked this pull request as ready for review March 3, 2025 22:56
@MananTank MananTank requested review from a team as code owners March 3, 2025 22:56
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (cb71dd5) to head (b5e02a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6406   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         874      874           
  Lines       54620    54620           
  Branches     3722     3722           
=======================================
  Hits        29895    29895           
  Misses      24630    24630           
  Partials       95       95           
Flag Coverage Δ
packages 54.73% <ø> (ø)

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 23:00 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 937 ms (0%) 134 ms (+59.94% 🔺) 1.1 s
thirdweb (cjs) 127.21 KB (0%) 2.6 s (0%) 284 ms (+15.63% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 73 ms (+482.5% 🔺) 185 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 17 ms (+414.33% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 95 ms (+391.84% 🔺) 483 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 4, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on removing unused components and simplifying the `CouponCard` functionality by streamlining the handling of coupon applications and eliminating the modal for sharing free wallets.

### Detailed summary
- Deleted multiple files related to `share-free-wallets-modal` and analytics components.
- Removed the dynamic import of `LazyShareFreeWalletsModal` in `CouponCard.tsx`.
- Simplified the `onCouponApplied` function signature by removing the `isFreeWalletsCoupon` parameter.
- Eliminated state management for `showShareModal` in `CouponSection`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 01:48 Inactive
@graphite-app graphite-app bot merged commit b5e02a4 into main Mar 4, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3590 branch March 4, 2025 01:55
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 4, 2025 01:55 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 4, 2025 01:55 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 4, 2025 01:55 Inactive
@vercel vercel bot temporarily deployed to Production – login March 4, 2025 01:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants