Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 4, 2025

blocked by: https://app.graphite.dev/github/pr/thirdweb-dev/api-server/1437/add-team-engine-management-endpoints


PR-Codex overview

This PR focuses on updating the handling of teamIdOrSlug in various components and utility functions related to engine instances and alerts, ensuring that the correct team context is maintained throughout the application.

Detailed summary

  • Added teamIdOrSlug parameter to multiple functions and components.
  • Updated API endpoints to include teamIdOrSlug in requests.
  • Modified components like EngineAlertsPage, EngineSystem, and EngineInstancesTable to pass teamIdOrSlug.
  • Adjusted query hooks to accept teamIdOrSlug for fetching data.
  • Ensured consistent usage of teamIdOrSlug across engine alert and instance management functionalities.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 24063af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 1:47am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 5, 2025 1:47am
login ⬜️ Skipped (Inspect) Mar 5, 2025 1:47am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 5, 2025 1:47am
wallet-ui ⬜️ Skipped (Inspect) Mar 5, 2025 1:47am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 07:56 Inactive
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Mar 4, 2025 — with Graphite App
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 4, 2025
@jnsdls jnsdls marked this pull request as ready for review March 4, 2025 07:56
@jnsdls jnsdls requested review from a team as code owners March 4, 2025 07:56
Copy link
Member Author

jnsdls commented Mar 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls force-pushed the update_engine_API_routes_to_include_team_slug branch from 9f15926 to 2d8fde0 Compare March 4, 2025 07:57
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 07:57 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 159 ms (+82.57% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 267 ms (+7.02% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 69 ms (+635.24% 🔺) 181 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 24 ms (+714.29% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 53 ms (+169.88% 🔺) 439 ms

@jnsdls jnsdls force-pushed the update_engine_API_routes_to_include_team_slug branch from 2d8fde0 to 4aacef1 Compare March 4, 2025 08:20
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 08:20 Inactive
@jnsdls jnsdls force-pushed the update_engine_API_routes_to_include_team_slug branch from 4aacef1 to 1da6d02 Compare March 5, 2025 01:32
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 5, 2025 01:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 5, 2025 01:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 5, 2025 01:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 5, 2025 01:32 Inactive
@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Mar 5, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.72%. Comparing base (e2c9d4d) to head (24063af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6407   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files         874      874           
  Lines       54621    54621           
  Branches     3722     3722           
=======================================
  Hits        29894    29894           
  Misses      24633    24633           
  Partials       94       94           
Flag Coverage Δ
packages 54.72% <ø> (ø)

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

Merge activity

blocked by: https://app.graphite.dev/github/pr/thirdweb-dev/api-server/1437/add-team-engine-management-endpoints

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the handling of `teamIdOrSlug` across various components and utility functions related to engine instances and alerts, ensuring that the correct team context is maintained throughout the application.

### Detailed summary
- Added `teamIdOrSlug` parameter to multiple functions and components.
- Updated API endpoints to include `teamIdOrSlug` in fetch calls.
- Modified components like `EngineAlertsPage`, `EngineSystem`, and `EngineInstancesTable` to pass `teamIdOrSlug`.
- Adjusted data structure handling in API responses to use `result` instead of `data`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the update_engine_API_routes_to_include_team_slug branch from 1da6d02 to 24063af Compare March 5, 2025 01:39
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 5, 2025 01:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 5, 2025 01:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 5, 2025 01:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 5, 2025 01:39 Inactive
@graphite-app graphite-app bot merged commit 24063af into main Mar 5, 2025
32 checks passed
@graphite-app graphite-app bot deleted the update_engine_API_routes_to_include_team_slug branch March 5, 2025 01:47
@vercel vercel bot temporarily deployed to Production – login March 5, 2025 01:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 5, 2025 01:47 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 5, 2025 01:47 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 5, 2025 01:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants