Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 4, 2025

PR-Codex overview

This PR focuses on enhancing the validation for the logo field in the create-ecosystem-form.client.tsx component by adding a file size constraint and modifying how the file is set in the form.

Detailed summary

  • Added a file size validation to the logo field, requiring it to be less than 500KB.
  • Updated the form.setValue method to include shouldValidate: true when setting the logo value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Mar 4, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 42bef2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 16:18 Inactive
@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 4:30pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 4, 2025 4:30pm
login ⬜️ Skipped (Inspect) Mar 4, 2025 4:30pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 4, 2025 4:30pm
wallet-ui ⬜️ Skipped (Inspect) Mar 4, 2025 4:30pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 16:18 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 4, 2025 16:18
@MananTank MananTank requested review from a team as code owners March 4, 2025 16:18
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 16:21 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 206 ms (+145.81% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 313 ms (+22.4% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 106 ms (+1612.22% 🔺) 218 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 57 ms (+1399.74% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 101 ms (+500.3% 🔺) 488 ms

@jnsdls jnsdls merged commit 158a08a into main Mar 4, 2025
29 of 30 checks passed
@jnsdls jnsdls deleted the tool-3598 branch March 4, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants