-
Notifications
You must be signed in to change notification settings - Fork 621
[TOOL-3606] playground: Remove Ethereum as default selected chain in insight playground #6413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6413 +/- ##
=======================================
Coverage 54.72% 54.72%
=======================================
Files 874 874
Lines 54621 54621
Branches 3722 3722
=======================================
Hits 29894 29894
Misses 24633 24633
Partials 94 94
|
Merge activity
|
…insight playground (#6413) <!-- start pr-codex --> ## PR-Codex overview This PR refines the logic for setting default values in the `values` object within the `blueprint-playground.client.tsx` file. It consolidates the conditions for assigning a default value to parameters. ### Detailed summary - Removed the specific check for `param.name === "chain"` that assigned a hardcoded value of `"1"`. - Simplified the condition to check if `param.schema` has a `type` and a `default` property. - Updated the assignment of `values[param.name]` to use `param.schema.default` when applicable, otherwise setting it to an empty string. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
d0f5b78 to
e2c9d4d
Compare

PR-Codex overview
This PR focuses on refactoring a conditional block in the
blueprint-playground.client.tsxfile to streamline the assignment of default values tovalues.Detailed summary
param.name === "chain"and its assignment tovalues.chain.param.schema.defaulttovalues[param.name]if it exists.values[param.name]is assigned an empty string.