Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 4, 2025

PR-Codex overview

This PR focuses on refactoring a conditional block in the blueprint-playground.client.tsx file to streamline the assignment of default values to values.

Detailed summary

  • Removed the specific check for param.name === "chain" and its assignment to values.chain.
  • Simplified the conditional structure to directly assign param.schema.default to values[param.name] if it exists.
  • Ensured that if no default is found, values[param.name] is assigned an empty string.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Mar 4, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: e2c9d4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 1:15am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 5, 2025 1:15am
login ⬜️ Skipped (Inspect) Mar 5, 2025 1:15am
thirdweb-www ⬜️ Skipped (Inspect) Mar 5, 2025 1:15am
wallet-ui ⬜️ Skipped (Inspect) Mar 5, 2025 1:15am

@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 4, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 23:29 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Mar 4, 2025
@MananTank MananTank marked this pull request as ready for review March 4, 2025 23:29
@MananTank MananTank requested review from a team as code owners March 4, 2025 23:29
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [TOOL-3606] Portal: Remove Ethereum as default selected chain in insight playground [TOOL-3606] playground: Remove Ethereum as default selected chain in insight playground Mar 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 389 ms (+78.02% 🔺) 1.4 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 713 ms (+9.11% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 86 ms (+337.47% 🔺) 198 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 61 ms (+814.64% 🔺) 70 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 55 ms (+17.28% 🔺) 442 ms

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.72%. Comparing base (0f6aa6b) to head (e2c9d4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6413   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files         874      874           
  Lines       54621    54621           
  Branches     3722     3722           
=======================================
  Hits        29894    29894           
  Misses      24633    24633           
  Partials       94       94           
Flag Coverage Δ
packages 54.72% <ø> (ø)

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

Merge activity

…insight playground (#6413)

<!-- start pr-codex -->

## PR-Codex overview
This PR refines the logic for setting default values in the `values` object within the `blueprint-playground.client.tsx` file. It consolidates the conditions for assigning a default value to parameters.

### Detailed summary
- Removed the specific check for `param.name === "chain"` that assigned a hardcoded value of `"1"`.
- Simplified the condition to check if `param.schema` has a `type` and a `default` property.
- Updated the assignment of `values[param.name]` to use `param.schema.default` when applicable, otherwise setting it to an empty string.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 5, 2025 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 5, 2025 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 5, 2025 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 5, 2025 01:14 Inactive
@graphite-app graphite-app bot merged commit e2c9d4d into main Mar 5, 2025
31 checks passed
@graphite-app graphite-app bot deleted the tool-3606 branch March 5, 2025 01:17
@vercel vercel bot temporarily deployed to Production – docs-v2 March 5, 2025 01:17 Inactive
@vercel vercel bot temporarily deployed to Production – login March 5, 2025 01:17 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 5, 2025 01:17 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www March 5, 2025 01:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants